Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add future transactions accessor to ValidatedPool #8673

Merged
1 commit merged into from
May 1, 2021

Conversation

tgmichel
Copy link
Contributor

Currently we can read the ready queue and the status from the validated pool, but there is no way of reading future transactions.

This PR proposes allowing to do so by adding a public method that reads the pool and collects a vector of transaction hashes and extrinsic data.

The motivation for this is to be able to:

  • Enable testing of future transactions in Frontier, so we can verify that this is correctly handled in the case of pallet-ethereum's unchecked extrinsics.
  • Implement commonly used ethereum RPC extensions like geth's txpool.

@tgmichel
Copy link
Contributor Author

@sorpaas we can also leverage this to remove the frontier-pending-transactions task.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 1, 2021
@bkchr
Copy link
Member

bkchr commented May 1, 2021

bot merge

@ghost
Copy link

ghost commented May 1, 2021

Trying merge.

@ghost
Copy link

ghost commented May 1, 2021

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@ghost ghost merged commit dab7d56 into paritytech:master May 1, 2021
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants