pallet-treasury | port to frame v2

[shamb0]

pallet-treasury | port to frame v2

related #7882

polkadot companion: paritytech/polkadot#2730

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: 
Thus any use of this pallet in construct_runtime! should be careful to update name 
in order not to break storage or to upgrade storage (moreover for instantiable pallet). 
If pallet is published, make sure to warn about this breaking change.

So users of the treasury pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the treasury pallet.

[gui1117]

some tests in bounties needs to be fix it seems, because treasury no longer export DefaultInstance.
Instead bounties should use the default instance () or just removing the instance generic

[gui1117]

would be good to make use of frame_support::storage::migration::move_storage_from_pallet in a migration function to move all storages, and then call this function either here in on_runtime_upgrade or in a polkadot companion at the runtime level

[shamb0]

would be good to make use of frame_support::storage::migration::move_storage_from_pallet in a migration function to move all storages, and then call this function either here in on_runtime_upgrade or in a polkadot companion at the runtime level

Thanks @thiolliere , will pick up for this week

[gui1117]

you need to compare the metadata to catch the miss like the constant.
Also master needs to be merged.

But otherwise looks good to me

[shamb0]

Thanks @thiolliere, pulled in review suggested comments & merged to master 👍

[gui1117]

CI is failing https://gitlab.parity.io/parity/substrate/-/jobs/868957

[shamb0]

Hello @thiolliere, extremely, sorry. Overlooked at CI builds & dependency. today will have a look on "continuous-integration/gitlab-check-polkadot-companion-build"

[gui1117]

looks good to me, some indentation are wrong though

[gui1117]

some deprecated usage of RawEvent must be fixed: https://gitlab.parity.io/parity/substrate/-/jobs/870164

[shamb0]

Fixed "some deprecated usage of RawEvent"

[shawntabrizi]

@thiolliere @shamb0 you must be careful here.

Parts of treasury, the Tips and Bounties sub-pallets use an old Storage Key, which would mean some kind of migration is needed. Maybe not relevant to this exact PR, but def something to watch out for.

[gui1117]

yes tips and bounty pallets will need migration.
For treasury both old pallet and new pallet use the prefix "Treasury" in kusama and polkadot.

[shawntabrizi]

@shamb0 this also went stale

Feel free to reopen if you update to master

[gui1117]

needs to merge master, and awaiting for another review.

I should also review the merge of master once done.