Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

contracts: Release as v3.0.0 and add reserved field to ContractInfoOf #8175

Merged
merged 8 commits into from
Feb 25, 2021
Merged

contracts: Release as v3.0.0 and add reserved field to ContractInfoOf #8175

merged 8 commits into from
Feb 25, 2021

Conversation

athei
Copy link
Member

@athei athei commented Feb 22, 2021 •
edited
Loading

Preparing pallet_contracts for release. It seems that this PR requires the release of a frame-benchmarks v3.1.0 before releasing contracts.

  • Update README.md
  • Add a CHANGELOG.md
  • Bump version numbers and allow publishing.
  • Add a _reserved field to ContractInfoOf for future proofing.

@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 22, 2021
@athei athei requested review from gnunicorn and ascjones February 22, 2021 17:23
ascjones
ascjones approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % typos

frame/contracts/CHANGELOG.md Outdated Show resolved Hide resolved
frame/contracts/CHANGELOG.md Outdated Show resolved Hide resolved
frame/contracts/CHANGELOG.md Outdated Show resolved Hide resolved
frame/contracts/CHANGELOG.md Outdated Show resolved Hide resolved
@ascjones ascjones mentioned this pull request Feb 22, 2021
Merged
@2075
Copy link
Contributor

2075 commented Feb 23, 2021

kan i haz?

@athei
Copy link
Member Author

athei commented Feb 24, 2021

kan i haz?

You will. Just a bit more patience :)

@athei athei changed the title contracts: Release as v3.0.0 contracts: Release as v3.0.0 and add reserved field to ContractInfoOf Feb 24, 2021
@gnunicorn gnunicorn mentioned this pull request Feb 24, 2021
Closed
@atenjin
Copy link
Contributor

atenjin commented Feb 25, 2021

Hope this pr could be merged today...

@gnunicorn gnunicorn merged commit debec91 into master Feb 25, 2021
@gnunicorn gnunicorn deleted the at-contracts-releasev3 branch February 25, 2021 16:04
jam10o-new pushed a commit to jam10o-new/substrate that referenced this pull request Feb 28, 2021
@athei @ascjones
@gnunicorn @jam10o-new
contracts: Release as v3.0.0 and add reserved field to `ContractInfoO…
84e47c2 
…f` (paritytech#8175)

* contracts: Update README

* contracts: Add CHANGELOG.md

* contracts: Bump version to v3.0.0 and allow publish

* Typos

Co-authored-by: Andrew Jones <ascjones@gmail.com>

* Improve wording in the changelog

* contracts: Add reserved field to ContractInfoOf for future proofing

* also bump frame-benchmarking

* update lockfile

Co-authored-by: Andrew Jones <ascjones@gmail.com>
Co-authored-by: Benjamin Kampmann <ben@parity.io>
@athei athei mentioned this pull request Mar 2, 2021
Closed
@gnunicorn gnunicorn mentioned this pull request Mar 4, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ascjones ascjones ascjones approved these changes

@gnunicorn gnunicorn gnunicorn approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
Smart Contracts
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@athei @2075 @atenjin @gnunicorn @ascjones @paritytech-ci