This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate examples to use pallet macro #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A0-please_review
gui1117
added
A0-please_review
| @@ -18,7 +18,7 @@ | |||
| //! Autogenerated weights for pallet_balances | |||
| //! | |||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 2.0.0 | |||
| //! DATE: 2021-01-06, STEPS: [50, ], REPEAT: 20, LOW RANGE: [], HIGH RANGE: [] | |||
| //! DATE: 2021-01-06, STEPS: \[50, \], REPEAT: 20, LOW RANGE: [], HIGH RANGE: [] | |||
There was a problem hiding this comment.
where is this change coming from?
do you need to update the weight template / output code?
There was a problem hiding this comment.
yes we probably need to update the templates,
rust doc complains the content inside [] is not a rust type
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7882
migrate pallet-example, pallet-example-offchain-worker and pallet-example-parallel to pallet macro.
the doc in pallet-example is slightly changed. Also it might be good to also have inherent, validate unsigned, and error docs but this is for later PR.
At some point I think the doc in frame_support::pallet and pallet-example should be merged