Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

contracts: Emit event on contract termination #8014

Merged
3 commits merged into from
Feb 2, 2021
Merged

Conversation

athei
Copy link
Member

@athei athei commented Feb 1, 2021

When the seal_terminate API was introduced no event was added. This adds the appropriate event and also removes the now redundant tombstone argument from the ContractEvicted event as it was always true.

Some renames and doc improvements where done as a drive-by.

@athei athei added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Feb 1, 2021
@athei athei requested a review from NikVolf February 1, 2021 11:20
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@athei
Copy link
Member Author

athei commented Feb 2, 2021

bot merge

@ghost
Copy link

ghost commented Feb 2, 2021

Trying merge.

@ghost ghost merged commit b201d7c into master Feb 2, 2021
@ghost ghost deleted the at-termination-event branch February 2, 2021 10:48
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants