This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Ensure transactional with ? works in frame v2 #7982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A2-insubstantial
apopiak
approved these changes
Jan 26, 2021
bkchr
approved these changes
Jan 26, 2021
|
The underlying issue is fixed with #7301 |
|
Yes but considering |
|
The original issue was that the code won't compile if |
|
ah indeed I see why it wouldn't compile, this PR wasn't needed, sorry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually I'm not sure it is needed to test for it as transactional macro is independant from frame v2, but anyway having it in the test might be better to show usage
cc @apopiak
EDIT: this comes from my missunderstood of Apopiak message, sorry