This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Refactor StorageInstance trait to be usable more easily
#7659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
B0-silent
kianenigma
approved these changes
Dec 2, 2020
bkchr
reviewed
Dec 2, 2020
frame/support/src/traits.rs
Outdated
| @@ -1733,11 +1733,10 @@ pub trait Instance: 'static { | |||
|
|
|||
| /// An instance of a storage. | |||
| /// | |||
| /// It is required the the couple `(PalletInfo::name<Pallet>(), STORAGE_PREFIX)` is unique. | |||
| /// It is required the the couple `(pallet_prefix(), STORAGE_PREFIX)` is unique. | |||
There was a problem hiding this comment.
we don't use it as a tuple, but just all storages must use different pallet_prefix and storage_prefix otherwise they would be after the same key twox_128(pallet_prefix)++twox_128(storage_prefix).
But the doc is not good, I updated
bkchr
approved these changes
Dec 2, 2020
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
darkfriend77
pushed a commit
to mogwaicoin/substrate
that referenced
this pull request
Jan 11, 2021
…#7659) * refactor StorageInstance to be usable without macros * better description * update types doc * Update frame/support/src/traits.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageInstanceis introduced to be used alongside storage types. It was meant to be implemented by macro, thus I tried to make it as straightforward as possible to implement from the macro (just some associated type and constant). But this is a rather ugly trait and it is less usable then.Thus this PR refactors it to make it more usable and idiomatic.