-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
should also publish OS/driver/build details. |
tests failing. |
TODO follow up from this PR:
|
So change benchmarking baseline machine means modify all the numbers? Good that we just start working on writing benchmarking and not yet reach to running benchmarking phase. Otherwise we will be wasting our time. |
@xlc we want to, at least to start, have 1_000 weight == 1 nanosecond. In general, until we launch polkadot, you should not expect that anything stays fixed. As Gav has mentioned, it is likely that the hardware specifications of weight calculation will change per major release, but for this first release, we are still exploring where we want to set the base level. |
So this means we shouldn't start benchmarking yet as the result may not be consistent with Substrate? |
@xlc You can def start to write benchmarking code, but running the final benchmarks and applying final weight values is something I might wait to do. |
(Wait until 2.0 release, where we will have 100% fixed the standard hardware configuration. That said, this is almost certainly that configuration.) |
bot merge |
Cannot merge; please ensure the pull request is mergeable and has approval from the project owner or at least 2 core devs. |
bot merge cancel |
We are using a faster machine than before to re-calculate our weights, which results in a drop in weight values of around 2x - 3x.
This PR updates weights for:
Current machine specifications:
lscpu - Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (expand)
lshw (expand)
fio disk benchmark (expand)
cargo version (expand)
Ubuntu 20.04 (expand)
lspci driver details(expand)
Ordered from:
https://www.ovh.co.uk/dedicated_servers/prices/