This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

New database trait #5549

Merged

arkpar merged 27 commits into master from gav-db-trait

Apr 15, 2020

Member

gavofyork commented Apr 6, 2020 •

edited by arkpar

Loading

Polkadot companion PR: paritytech/polkadot#996

gavofyork added 6 commits

April 6, 2020 19:25


          Introduce trait


          The trait

67aee75


          Generic

901b8de


          Basic impls.

4df786f


          Remove unneeded bounds

0ffa2d7


          Minor changes

6880b2c

gavofyork requested a review from arkpar

April 6, 2020 20:48

gavofyork added the A0-please_review label

NikVolf reviewed

View reviewed changes

primitives/database/src/lib.rs Show resolved Hide resolved

NikVolf reviewed

View reviewed changes

primitives/database/src/lib.rs Show resolved Hide resolved

NikVolf reviewed

View reviewed changes

primitives/database/src/lib.rs Show resolved Hide resolved

NikVolf reviewed

View reviewed changes

primitives/database/src/lib.rs Show resolved Hide resolved

NikVolf reviewed

View reviewed changes

primitives/database/src/lib.rs Show resolved Hide resolved


          Switch over to the new DB trait

e25020e

gavofyork requested a review from cecton as a code owner

April 7, 2020 15:20

arkpar added the A1-onice label

arkpar and others added 6 commits

April 7, 2020 18:25


          Merge branch 'master' of github.com:paritytech/substrate into gav-db-…

65a660e

…trait


          Integrated parity-db and added CLI for db selection

ad4b010


          Default impl.

2f6402c


          Merge branch 'gav-db-trait' of github.com:paritytech/substrate into g…

22eaf93

…av-db-trait


          Merge remote-tracking branch 'origin/master' into gav-db-trait

35bc233


          Fix logs.

49e197e

gavofyork requested review from andresilva, Demi-Marie, kianenigma and gui1117 as code owners

April 8, 2020 09:21

paritytech-ci added the B2-breaksapi label


          Started integrating subdb

2e64815

cecton suggested changes

View reviewed changes

Contributor

cecton left a comment

Just reviewing the CLI parts. There are a few issues but I proposed a fix for all of them

client/cli/src/config.rs Outdated Show resolved Hide resolved

client/cli/src/commands/mod.rs Show resolved Hide resolved

client/cli/src/config.rs Outdated Show resolved Hide resolved

client/cli/src/params/shared_params.rs Outdated Show resolved Hide resolved

client/cli/src/params/shared_params.rs Outdated Show resolved Hide resolved

arkpar and others added 6 commits

April 9, 2020 09:59


          Apply suggestions from code review

Co-Authored-By: Cecile Tonglet <cecile@parity.io>


          Apply suggestions from code review

14e319a

Co-Authored-By: Nikolay Volf <nikvolf@gmail.com>


          Enable subdb

817663e


          Merge remote-tracking branch 'origin/master' into gav-db-trait

f5e2de2


          Bump parity-db


          Fixed CLI macro

8c69d5a

gavofyork added A8-mergeoncegreen and removed A0-please_review labels

arkpar added 2 commits

April 14, 2020 12:41


          Fixed browser build


          Fixed features

1b8ffb9

arkpar removed the A1-onice label

arkpar mentioned this pull request

Updated for the new db paritytech/polkadot#996

Merged

arkpar reviewed

View reviewed changes

Member

arkpar left a comment

This changes the ways leaves are encoded in the DB. It is my understanding that the database upgrade is not really required though, as finality can progress anyway and leaves are overwritten after a few blocks are imported.

gnunicorn requested a review from cecton

April 14, 2020 14:34

gnunicorn assigned cecton

gnunicorn added A1-onice and removed A1-onice labels

arkpar added 3 commits

April 15, 2020 13:07


          Merge branch 'master' of github.com:paritytech/substrate into gav-db-…

262819e

…trait


          Sort out features

beccecf


          Merge branch 'master' of github.com:paritytech/substrate into gav-db-…

6e69a80

…trait

arkpar removed the A3-needsresolving label

pepyakin reviewed

View reviewed changes

client/cli/src/arg_enums.rs Outdated Show resolved Hide resolved

arkpar added 2 commits

April 15, 2020 13:53


          Use parity-db from crates.io

e22f4d1


          Typo

16c813a

arkpar merged commit 88248c0 into master

arkpar deleted the gav-db-trait branch

April 15, 2020 12:38

Contributor

tomaka commented Apr 15, 2020 •

edited

Loading

I think master is now broken because we depend on a git repo that depends on this branch:

substrate/client/db/Cargo.toml

Line 38 in 88248c0

subdb = { git = "https://github.com/paritytech/subdb", optional = true }
https://github.com/paritytech/subdb/blob/master/Cargo.toml#L25

This also temporarily makes Substrate un-publish-able on crates.io

davxy mentioned this pull request

Remove unused leaves-set fields #11895

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

pepyakin pepyakin left review comments

NikVolf NikVolf left review comments

arkpar arkpar left review comments

andresilva Awaiting requested review from andresilva

Demi-Marie Awaiting requested review from Demi-Marie

kianenigma Awaiting requested review from kianenigma

gui1117 Awaiting requested review from gui1117

cecton Awaiting requested review from cecton

Labels

None yet