This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add cargo-deny job #5347
Merged
add cargo-deny job #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
reviewed
Mar 22, 2020
.maintain/deny.toml
Outdated
| # https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html | ||
| [bans] | ||
| # Lint level for when multiple versions of the same crate are detected | ||
| multiple-versions = "deny" |
There was a problem hiding this comment.
The paritytech/polkadot#922 was only about parity-util-mem (because it was causing issues), I don't think it's possible to get rid of duplicates for every single dependency.
There was a problem hiding this comment.
We wanted to introduce those checks (duplicate deps, licenses, advisories and sources) for a long time anyway.
If it's not possible to avoid the dependency duplication, then there's bans.skip list to add them there temporarily.
kirushik
reviewed
Mar 23, 2020
.maintain/deny.toml
Outdated
| #"Nokia", | ||
| ] | ||
| # Lint level for licenses considered copyleft | ||
| copyleft = "deny" |
There was a problem hiding this comment.
This is rather strange — why deny copyleft, but then explicitly allow GPL-3.0 a few lines above?
gavofyork
added
the
A2-insubstantial
TriplEight
added
the
A3-in_progress
…ncies dupes and advisories
…eny_for_substrate
kirushik
approved these changes
Mar 24, 2020
TriplEight
removed
the
A3-in_progress
This was referenced Mar 24, 2020
rakanalh
pushed a commit
to rakanalh/substrate
that referenced
this pull request
Mar 25, 2020
* add cargo-deny job * feat(ci): add cargo-deny CI job, checks registries, licenses, dependencies dupes and advisories
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves paritytech/polkadot#922
parity-util-mem <0.6