This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Benchmark Collective Pallet #5343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcio-diaz
added
the
A3-in_progress
|
The balances module also has instantiation. Why was there no issue there? |
I guess the code generated by the macro is different when it's actually instantiated. But yeah, good point, I'll check deeper. \cc @thiolliere |
|
I guess it can related to the fact that node-runtime only use balance with default instance whereas collective is used with non default instance. |
|
@thiolliere Do you see a cleaner way to solve this problem? Or do you agree this is a good hack for now? |
shawntabrizi
previously requested changes
Mar 23, 2020
marcio-diaz
added
A0-please_review
shawntabrizi
added
A8-mergeoncegreen
and removed
A0-please_review
rakanalh
pushed a commit
to rakanalh/substrate
that referenced
this pull request
Mar 25, 2020
* Init * Fix execute. * Duplicate macro for instances temporarilly * Add propose. * Add vote, close. * Propose from own module * Add old members to set_members. * Add previous proposals to propose. * Compress a bit the macro. Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the problems I found is that the module is instantiated. So it seems I should call it from
Councillike this:but
run_benchmarkfrom the benchmarking macro is not implemented forModule<T, I>, only forModule<T>.