This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove deprecated API #4993
Merged
Remove deprecated API #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
added
the
A3-in_progress
stanislav-tkach
commented
Feb 19, 2020
| )? | ||
| { | ||
| // Run compatibility fallback for v3. | ||
| self.api.map_api_result(|api| { |
There was a problem hiding this comment.
I'm not sure if this should be removed.
stanislav-tkach
requested review from
andresilva and
Demi-Marie
as code owners
|
|
stanislav-tkach
changed the title
stanislav-tkach
added
A0-please_review
bkchr
approved these changes
Feb 20, 2020
shawntabrizi
approved these changes
Feb 20, 2020
gnunicorn
added
A5-grumble
and removed
A0-please_review
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 4, 2020
* Remove deprecated API * Remove (some) allow(dead_code) * Bump spec_version * Fix import, remove allow dead code. Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated api and dead code before 2.0 release.
Closes #4935.