This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Rename StorageMap::exists to ::contains_key (Resolves #4839) #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
added
the
A3-in_progress
apopiak
requested review from
kianenigma,
pepyakin and
gui1117
as code owners
|
It looks like @apopiak hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
|
[clabot:check] |
|
It looks like @apopiak signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
apopiak
added
A0-please_review
apopiak
force-pushed
the
apopiak-rename-exists-to-contains-key
branch
from
16540a4 to
83d1128
Compare
bkchr
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #4839 it would be nice to align the
StorageMapinterface with the ones provided by RustsHashMapandBTreeMap.This PR renames
StorageMap::exists(key)toStorageMap::contains_key(key)(and adjusts usage in pallets).As I don't have a good overview of substrate, yet, please let me know which documentation needs to change.
See paritytech/polkadot#827 and polkadot-developers/substrate-developer-hub.github.io#445 for the companion PRs.