This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Enumeratable dispatches using unhashed index in key #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A2-insubstantial
jacogr
approved these changes
Dec 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now although we can enumerate all values of the
democracy::DispatchQueuemapping, we cannot enumerate all the keys. This is a general failing ofmap, since it will be default use a cryptographic hash (Blake2) to index the item, which is by design not useful for deriving the key itself.This uses a non-cryptographic hash (the key material is a block number coming from a high-friction governance process and cannot be easily or cheaply gamed) along with the index itself, allowing the index to be derived from the database key.
CC @jacogr