It's Clippy time! #3806
It's Clippy time! #3806
Conversation
c410-f3r
requested review from
andresilva,
Demi-Marie,
kianenigma,
gui1117 and
tomusdrw
as code owners
|
It looks like @c410-f3r signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
To remove all hard errors, more research is needed, specially inside the |
| @@ -178,7 +178,7 @@ macro_rules! implement_per_thing { | |||
| // `rem_multiplied_upper` is less than $max^2 therefore divided by $max it fits | |||
| // in $type. remember that $type always fits $max. | |||
| let mut rem_multiplied_divided_sized = | |||
| (rem_multiplied_upper / upper_max) as $type; | |||
| rem_multiplied_upper.div(upper_max) as $type; | |||
There was a problem hiding this comment.
It is just to avoid https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl. Probably a false-positive
There was a problem hiding this comment.
Could you please revert this? We should not include fixes for false positives in clippy.
| @@ -178,7 +178,7 @@ macro_rules! implement_per_thing { | |||
| // `rem_multiplied_upper` is less than $max^2 therefore divided by $max it fits | |||
| // in $type. remember that $type always fits $max. | |||
| let mut rem_multiplied_divided_sized = | |||
| (rem_multiplied_upper / upper_max) as $type; | |||
| rem_multiplied_upper.div(upper_max) as $type; | |||
There was a problem hiding this comment.
Could you please revert this? We should not include fixes for false positives in clippy.
|
@c410-f3r you need to merge master. |
Fix some Clippy issues
|
@bkchr Merged |
|
Ty |
|
Thanks |
Compliance with all default hard errors and crates that are explicitly
using
#![deny(warnings)].There are some legitimate warnings like
println!("")->println!()butthey aren't considered in this PR.