This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add execute_with to TestExternalities
#3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function executes the given closure in a context where the test externalities are set. This makes the srml tests easier to write, as the test externalities need to be created anyway.
bkchr
added
A0-please_review
bkchr
requested review from
andresilva,
Demi-Marie,
jimpo,
kianenigma,
pepyakin and
gui1117
as code owners
kianenigma
approved these changes
Oct 10, 2019
gui1117
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
All it does is adding the function TestExternalities, removing the re-export in primitives, and changing test for new API if I'm correct.
I like this, also I think this can allow us to move from TestExternalities duplicating code from Ext itself.
At the time I couldn't make the function with_externalities or now set_and_run_with_externalities working with Ext<InMemoryStuff..> because of borrowing issues, but now maybe we can just wrap Ext<InMemoryStuff..> and have this function on top or something to reuse most code. But let's try in following PR.
HCastano
added a commit
to HCastano/substrate
that referenced
this pull request
Oct 22, 2019
HCastano
added a commit
that referenced
this pull request
Oct 23, 2019
HCastano
added a commit
to HCastano/substrate
that referenced
this pull request
Nov 11, 2019
…tytech#3874) * Make tests work after the changes introduced in paritytech#3793 * Remove unneccessary import
HCastano
added a commit
that referenced
this pull request
Dec 12, 2019
HCastano
added a commit
that referenced
this pull request
Jan 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function executes the given closure in a context where the test
externalities are set. This makes the srml tests easier to write, as the
test externalities need to be created anyway.
After having the discussion with @jimpo in my last pr about some function re-exporting, I came to this idea :) As written above, I think it makes tests more easily writable.
The diff is huge, but it is mostly just replacing function calls.