This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix nodes not connecting to each other #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the fact that nodes would only connect to bootstrap nodes (for which the address is known in advance) and not to one another, since they didn't learn about the other nodes' addresses. |
|
Nodes should always advertise external address, not the one they are listening on. |
|
On the theoretical level, the situation is kind of a mess because we are so generic over the multiaddress. Routing with libp2p in general should be re-though. But you're right ; since in practice we only use TCP/IP I made the change to only report external addresses. |
arkpar
approved these changes
Jul 16, 2018
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
fix the following error in the log: Could not extract candidates from block body of imported block ...
JoshOrndorff
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
Some fields of the RuntimeAPI/RPC output were incorrectly named.
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Update version 0.9.1 * Format code * Modify decoding mode (paritytech#318) * Update chainspec V0.9.1 * Change sudo & council_address * Fix Signature coverage (paritytech#330) * Update V0.9.2 * Feature/xbridge log (paritytech#331) * Update log * Update wasm
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Fix the initialization of TotalBalance in balances * Update Cargo.lock
liuchengxu
added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…-metadata Fix the secondary runtime metadata
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
…on (paritytech#330) * Update balances events * Update node_runtime.scale * Update default extra to include ChargeAssetTxPayment with extra field * Fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a local node answers a Kademlia query about itself, it needs to return the locally-known addresses it's listening on, instead of the content of its peer store which is going to be empty.