Runtime version #256

arkpar · 2018-06-27T11:53:48Z

Closes #241

Does not have any performance optimisations.
I've also removed CheckedId because it is now obsoleted by the version check and should be handled by the substrate, rather than polkadot anyway.

…ime-ver

pepyakin · 2018-06-27T12:18:13Z

substrate/runtime/version/src/lib.rs

+}
+
+impl<T: Trait> Module<T> {
+	/// Get runtime verions


typo: version?

pepyakin · 2018-06-27T12:19:57Z

substrate/runtime/version/src/lib.rs

+
+#[cfg(feature = "std")]
+impl RuntimeVersion {
+	/// Check if this version matches other version for calling into runtime.


can we copy descriptions from the issue? They're pretty descriptive there...

pepyakin · 2018-06-27T12:20:23Z

substrate/runtime/version/src/lib.rs

+// You should have received a copy of the GNU General Public License
+// along with Substrate Demo.  If not, see <http://www.gnu.org/licenses/>.
+
+//! Version module for runtime; Provide a function that returns runtime verion.


s/verion/version

pepyakin · 2018-06-27T12:28:54Z

polkadot/runtime/src/lib.rs

@@ -102,6 +105,22 @@ pub type Block = generic::Block<Header, UncheckedExtrinsic>;
 #[cfg_attr(feature = "std", derive(Debug, Serialize, Deserialize))]
 pub struct Concrete;

+/// Polkadot runtime version.
+pub const VERSION: RuntimeVersion = RuntimeVersion {
+	spec_name: ver_str!("polkatot"),


s/polkatot/polkadot

pepyakin · 2018-06-27T12:29:08Z

demo/runtime/src/lib.rs

@@ -59,6 +62,22 @@ pub use runtime_primitives::BuildStorage;
 /// Concrete runtime type used to parameterize the various modules.
 pub struct Concrete;

+/// Polkadot runtime version.


demo runtime version?

gavofyork · 2018-06-28T15:00:21Z

substrate/client/src/error.rs

@@ -70,6 +70,12 @@ error_chain! {
 			display("Current state of blockchain has invalid authority count value"),
 		}

+		/// Invalid state data.
+		VersionInvalid {


Should just assume it's the PoC-1 runtime in this case for now, once we ditch the PoC-1 chain that assumption can be removed and this error can be reinstated.

gavofyork

Pending the couple of minor changes mentioned.

gavofyork

Withdrawing approval until it's clear that the field descriptions of the original issue were faithfully followed.

gavofyork

paritytech/polkadot#241

…ime-ver

arkpar · 2018-06-30T10:51:12Z

Addressed all issues

gavofyork · 2018-07-01T08:43:04Z

quoting #241:

Actually, there is one addendum: authorship should require authoring_version and spec_name to be identical. But not spec_version.

rphmeier · 2018-07-02T09:15:03Z

I've also removed CheckedId because it is now obsoleted by the version check and should be handled by the substrate, rather than polkadot anyway.

Why? CheckedId is a type-safe handle to indicate that a block exists. It says "this block ID corresponds to data we know locally", which is a useful tool and IMO is not obsoleted by the version check, which tells you if a known block corresponds to a certain runtime version.

arkpar · 2018-07-02T09:45:56Z

@rphmeier I don't see why it should be checked by the polkadot API and not the substrate. Also, CheckedId does not guarantee anything since the state can be pruned away any time after the check. Does not look safe to me.

arkpar · 2018-07-02T09:50:05Z

@gavofyork Added that last bit

gavofyork · 2018-07-02T10:23:25Z

substrate/runtime/version/src/lib.rs

+#[cfg(feature = "std")]
+#[macro_export]
+macro_rules! ver_str {
+	( $y:expr ) => {{ ::std::borrow::Cow::Borrowed($y) }}


question: why using Cow for std?

So that it can be defined as const and deserialised from Slicable using the same type.

…tions (paritytech#256) * strip out all ICMP code and begin gossip refactor * validate incoming statements * message_allowed logic * compiles * do reporting and neighbor packet validation * tests compile * propagate gossip messages * test message_allowed * some more tests * address grumbles

* kill processes on exit and sigint * retyped events and updated api

Updated Farming commands to reflect current snapshot

arkpar added 3 commits June 27, 2018 13:06

Runtime version

b071016

Updated genesis.wasm

1546854

Merge branch 'master' of github.com:paritytech/polkadot into ark-runt…

4f8c8cb

…ime-ver

arkpar added the A0-please_review Pull request needs code review. label Jun 27, 2018

pepyakin reviewed Jun 27, 2018

View reviewed changes

arkpar added 2 commits June 27, 2018 16:28

Minor fixes

d80e679

Fresh runtime

97e3e43

gavofyork reviewed Jun 28, 2018

View reviewed changes

gavofyork approved these changes Jun 28, 2018

View reviewed changes

gavofyork reviewed Jun 28, 2018

View reviewed changes

gavofyork suggested changes Jun 28, 2018

View reviewed changes

arkpar added 2 commits June 30, 2018 12:38

Default version for pre Poc-2; Fixed authorship interface check

2aaf176

Merge branch 'master' of github.com:paritytech/polkadot into ark-runt…

e024cfd

…ime-ver

Fixed authoring check

3139f18

gavofyork reviewed Jul 2, 2018

View reviewed changes

gavofyork approved these changes Jul 2, 2018

View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jul 2, 2018

Merge remote-tracking branch 'origin/master' into ark-runtime-ver

7cf7812

gnunicorn mentioned this pull request Jul 3, 2018

Improve Runtime execution by caching runtime lookup #276

Merged

gavofyork merged commit 710ae51 into master Jul 3, 2018

gavofyork deleted the ark-runtime-ver branch July 3, 2018 15:44

JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021

Antoine kill processes test and improve api (paritytech#256)

a82df9f

* kill processes on exit and sigint * retyped events and updated api

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022

Merge pull request paritytech#256 from subspace/readme-update

39f4f8c

Updated Farming commands to reflect current snapshot

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Runtime version #256

Runtime version #256

arkpar commented Jun 27, 2018

pepyakin Jun 27, 2018

pepyakin Jun 27, 2018

pepyakin Jun 27, 2018

pepyakin Jun 27, 2018

pepyakin Jun 27, 2018

gavofyork Jun 28, 2018 •

edited

Loading

gavofyork left a comment

gavofyork left a comment

gavofyork left a comment

arkpar commented Jun 30, 2018

gavofyork commented Jul 1, 2018

rphmeier commented Jul 2, 2018

arkpar commented Jul 2, 2018

arkpar commented Jul 2, 2018

gavofyork Jul 2, 2018

arkpar Jul 2, 2018

Runtime version #256

Runtime version #256

Conversation

arkpar commented Jun 27, 2018

pepyakin Jun 27, 2018

Choose a reason for hiding this comment

pepyakin Jun 27, 2018

Choose a reason for hiding this comment

pepyakin Jun 27, 2018

Choose a reason for hiding this comment

pepyakin Jun 27, 2018

Choose a reason for hiding this comment

pepyakin Jun 27, 2018

Choose a reason for hiding this comment

gavofyork Jun 28, 2018 • edited Loading

Choose a reason for hiding this comment

gavofyork left a comment

Choose a reason for hiding this comment

gavofyork left a comment

Choose a reason for hiding this comment

gavofyork left a comment

Choose a reason for hiding this comment

arkpar commented Jun 30, 2018

gavofyork commented Jul 1, 2018

rphmeier commented Jul 2, 2018

arkpar commented Jul 2, 2018

arkpar commented Jul 2, 2018

gavofyork Jul 2, 2018

Choose a reason for hiding this comment

arkpar Jul 2, 2018

Choose a reason for hiding this comment

gavofyork Jun 28, 2018 •

edited

Loading