Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump master to v2.0.0 #2514

Merged
merged 4 commits into from
May 10, 2019
Merged

Bump master to v2.0.0 #2514

merged 4 commits into from
May 10, 2019

Conversation

andresilva
Copy link
Contributor

This is needed to tag master clients appropriately (otherwise they show up as v1.0 on telemetry).

@andresilva andresilva added the A0-please_review Pull request needs code review. label May 8, 2019
@andresilva
Copy link
Contributor Author

I can bump the spec_version to appease the bot but it seems unnecessary.

@gavofyork
Copy link
Member

needs resolving.

@gavofyork gavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A3-needsresolving and removed A0-please_review Pull request needs code review. A4-gotissues labels May 9, 2019
@xlc
Copy link
Contributor

xlc commented May 9, 2019

Should the versions be 2.0.0-alpha to indicate this is pre-release version?

@koushiro
Copy link
Contributor

koushiro commented May 9, 2019 •
edited
Loading

It's so weird that Substrate will bump version to v2.0.0 directly before releasing version 1.0.
I think the breaking changes are acceptable in the rc phase currently, because the Substrate is not published to crates.io.

@andresilva
Copy link
Contributor Author

The master branch has breaking changes that are not compatible with v1.0. We won't be releasing v2.0 anytime soon, just tagging the master branch appropriately so that when we build (incompatible) substrate binaries they're not tagged as v1.0. We will release a v1.1 version (way before v2.0 is done), but that will be done by manually backporting changes from master to the v1 branch. I don't have any opinion on whether this should be tagged 2.0.0 or 2.0.0-alpha, I'm fine with either.

(This change is in the context of launching a new testnet that runs substrate master. I don't want the nodes to show up as 1.0 on telemetry).

@andresilva andresilva force-pushed the andre/v2.0 branch 3 times, most recently from 83dc119 to 8722e41 Compare May 10, 2019 09:27
@andresilva andresilva added A0-please_review Pull request needs code review. and removed A3-needsresolving labels May 10, 2019
@gavofyork gavofyork merged commit 6e67eff into master May 10, 2019
@gavofyork gavofyork deleted the andre/v2.0 branch May 10, 2019 14:55
MTDK1 pushed a commit to bdevux/substrate that referenced this pull request Jul 10, 2019
@andresilva @MTDK1
Bump master to v2.0.0 (paritytech#2514)
4bda736 
* bump crates to v2.0.0

* fix crate authors

* bump node runtime spec_version

* remove unused import for no-std
rimbi pushed a commit to moonbeam-foundation/substrate that referenced this pull request Jul 27, 2023
Fix the wasm runtime substitute caching bug (paritytech#2514)
b3bc87a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andresilva @gavofyork @xlc @koushiro @bkchr @devops-parity