This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove the multiplexed networking system #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Apr 25, 2019
bkchr
added
A7-looksgoodtestsfail
and removed
A0-please_review
tomaka
added a commit
to tomaka/polkadot
that referenced
this pull request
May 6, 2019
* Remove the multiplexed networking system * Rename BackCompat to Normal * Remove CustomMessageId * Fix tests
gavofyork
pushed a commit
that referenced
this pull request
May 6, 2019
* ProtocolId can now be more than 3 bytes (#2350) * Update to libp2p v0.7.0 (#2343) * Update to libp2p master * Fix tests * More tests fixing * Remove the multiplexed networking system (#2373) * Remove the multiplexed networking system * Rename BackCompat to Normal * Remove CustomMessageId * Fix tests * Allow multiple substreams (#2379) * Allow multiple substreams * Update core/network-libp2p/src/custom_proto/handler.rs Co-Authored-By: tomaka <pierre.krieger1708@gmail.com> * Fix #2403 (#2404) * Fix #2403 * Apply suggestions from code review Co-Authored-By: tomaka <pierre.krieger1708@gmail.com> * Split Context::send_message into multiple methods (#2409) * Split Context::send_message into multiple methods * Apply suggestions from code review Co-Authored-By: tomaka <pierre.krieger1708@gmail.com> * Add reason for closing and fix multiple substreams (#2437) * Simplify the code of connection_keep_alive (#2438) * Drop connections when the handler gets disabled (#2439) * Drop connections when the handler gets disabled * Add test * Disable mDNS when passing --dev (#2467) * Show more information when too many addresses are reported (#2473) * Show more information when too many addresses are reported * Update core/network-libp2p/src/behaviour.rs Co-Authored-By: tomaka <pierre.krieger1708@gmail.com>
gavofyork
pushed a commit
that referenced
this pull request
May 6, 2019
* ProtocolId can now be more than 3 bytes (#2350) * Update to libp2p v0.7.0 (#2343) * Update to libp2p master * Fix tests * More tests fixing * Remove the multiplexed networking system (#2373) * Remove the multiplexed networking system * Rename BackCompat to Normal * Remove CustomMessageId * Fix tests * Allow multiple substreams (#2379) * Allow multiple substreams * Update core/network-libp2p/src/custom_proto/handler.rs Co-Authored-By: tomaka <pierre.krieger1708@gmail.com> * Fix #2403 (#2404) * Fix #2403 * Apply suggestions from code review Co-Authored-By: tomaka <pierre.krieger1708@gmail.com> * Split Context::send_message into multiple methods (#2409) * Split Context::send_message into multiple methods * Apply suggestions from code review Co-Authored-By: tomaka <pierre.krieger1708@gmail.com> * Add reason for closing and fix multiple substreams (#2437) * Simplify the code of connection_keep_alive (#2438) * Drop connections when the handler gets disabled (#2439) * Drop connections when the handler gets disabled * Add test * Disable mDNS when passing --dev (#2467) * Show more information when too many addresses are reported (#2473) * Show more information when too many addresses are reported * Update core/network-libp2p/src/behaviour.rs Co-Authored-By: tomaka <pierre.krieger1708@gmail.com> * Silence some errors
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
* Remove the multiplexed networking system * Rename BackCompat to Normal * Remove CustomMessageId * Fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1692
"Reverts" #1517
#1517 added a new network system based on opening one new substream for each request, but kept the old networking code on the side for backwards compatibility. This was IMO a step in the right direction. However since it isn't properly tested, this new system wasn't enabled by default.
This pull request removes this system and renames "backwards compatibility mode" into "normal mode".
This PR doesn't fix any issue and doesn't change anything on the wire, but has the objective of greatly simplifying the code.
I intend to open another PR on top of this.