This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Balances contract implementation #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomusdrw
commented
Nov 14, 2017
tomusdrw
commented
- Add sender to externalities.
rphmeier
reviewed
Nov 14, 2017
contracts/src/balances.rs
Outdated
| }) | ||
| } | ||
|
|
||
| fn contains_sender(sender: Address, addresses: &[Address]) -> bool { |
There was a problem hiding this comment.
it's more idiomatic for these to be free functions in the module
There was a problem hiding this comment.
also slice has a \.contains method already which is pretty fast.
rphmeier
reviewed
Nov 15, 2017
contracts/src/balances.rs
Outdated
| @@ -88,10 +84,10 @@ impl Contract { | |||
| pub fn transfer_preconditions<E: StaticExternalities<RustExecutor>>(&self, ext: &E, data: Transfer) -> Result<Option<Address>> { | |||
| // Check the caller: | |||
| let sender = ext.sender(); | |||
| if !Self::contains_sender(*sender, &[ | |||
| if !&[ | |||
There was a problem hiding this comment.
the & may not be necessary
|
Closing, since we won't need balances contract. |
iStrike7
referenced
this pull request
in gasp-xyz/substrate
Aug 3, 2021
default formatter rules enforced, linter errors supressed
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Trim network module * Format code and add client import stream * Fix block import notify network * Fix validator AUTHORITY roles
pmikolajczyk41
referenced
this pull request
in pmikolajczyk41/substrate
Aug 16, 2022
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Define default `node_runtime` compatible Runtime * rustfmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.