This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
More compact bytes serialization and code re-use. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
reviewed
Nov 11, 2017
primitives/src/bytes.rs
Outdated
| S: Serializer, | ||
| { | ||
| let mut non_zero = bytes.len(); | ||
| for (i, b) in bytes.iter().enumerate() { |
There was a problem hiding this comment.
Could be just bytes.iter().take_while(|b| *b == 0).count()
arkpar
reviewed
Nov 11, 2017
primitives/src/bytes.rs
Outdated
| ErrorKind::InvalidLength(len) => E::invalid_length(len, &self), | ||
| })?; | ||
|
|
||
| let v = if v.len() % 2 == 0 { v[2..].to_owned() } else { format!("0{}", &v[2..]) }; |
There was a problem hiding this comment.
I'd prefer non-even length to be an error.
arkpar
approved these changes
Nov 11, 2017
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Fix validator key error * 1.add balance module 2.add gitignore * Support dev mod and local test mod(paritytech#15) * Configure two validator Alice or Bob * Support dev mod and local test mod * 1.add balance module (paritytech#14) 2.add gitignore * update gitignore * fix genesis config * update runtime privcall * Fix genesis config (paritytech#16) * 1.add balance module 2.add gitignore * update gitignore * fix genesis config * update runtime privcall * add cargo.lock in runtime/wasm
Merged
gilescope
pushed a commit
that referenced
this pull request
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.