This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
bump ed25519-dalek to 2.0 #14776
Merged
bump ed25519-dalek to 2.0 #14776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
andresilva
force-pushed
the
andre/bump-ed25519-dalek
branch
from
e414bdd
to
3c6bf39
Compare
andresilva
force-pushed
the
andre/bump-ed25519-dalek
branch
from
3c6bf39
to
512d241
Compare
|
Should probably be burned-in to make sure nothing breaks. |
andresilva
added
the
A1-needs_burnin
Can probably don while we wait for the snow release. |
|
We'll still have |
andresilva
added
the
D5-nicetohaveaudit ⚠️
|
Took the liberty to remove the snow patch here since 0.9.3 has been released in the meantime (and I am also needing the new version for a PR of mine). |
|
Can we merge this? Substrate master CI needs it. |
bkchr
approved these changes
Aug 21, 2023
This was referenced Aug 21, 2023
skunert
approved these changes
Aug 21, 2023
davxy
approved these changes
Aug 21, 2023
|
bot merge |
|
Waiting for commit status. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rustsec.org/advisories/RUSTSEC-2022-0093
Can't merge until mcginty/snow#164 to remove cargo patch in this PR.
There is also
ed25519-zebra"4.0" available, but can't update to it for the same reason as above. Zebra is unaffected by this issue though.polkadot companion: paritytech/polkadot#7648
cumulus companion: paritytech/cumulus#3038