Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert "chore: update libp2p to 0.52.1 (#14429)" #14722

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

altonen
Copy link
Contributor

@altonen altonen commented Aug 6, 2023

This reverts commit d38d176.

polkadot companion: paritytech/polkadot#7583
cumulus companion: paritytech/cumulus#2975

@altonen altonen added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 6, 2023
@altonen altonen requested review from vstakhov, alindima, sandreim and a team August 6, 2023 11:38
Copy link
Contributor

@dmitry-markin dmitry-markin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required due to V1Lazy stuff?

@dmitry-markin dmitry-markin requested a review from kpp August 7, 2023 08:57
Copy link
Contributor

@vstakhov vstakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like the sense of reverting updates, but it seems that 0.51 behaves more stable in terms of network connectivity (at least as we can see on Versi).

frame/support/Cargo.toml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team August 7, 2023 11:01
@altonen
Copy link
Contributor Author

altonen commented Aug 7, 2023

@dmitry-markin

It's due to DHT issues we're experiencing on Versi. I'll get back to this upgrade soon enough but in the mean time we have to revert because I don't know how long it's going to take to figure out the underlying issues and there are other important tasks as well.

@rphmeier
Copy link
Contributor

This should be merged, no?

As far as we know, libp2p 0.52.1 is broken and should be taken out of master ASAP, right?

@altonen
Copy link
Contributor Author

altonen commented Aug 15, 2023

This should be merged, no?

As far as we know, libp2p 0.52.1 is broken and should be taken out of master ASAP, right?

yeah, just missing one last review from cumulus companion

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3397107

@bkchr
Copy link
Member

bkchr commented Aug 16, 2023

bot merge force

@paritytech-processbot paritytech-processbot bot merged commit e53cf32 into master Aug 16, 2023
3 checks passed
@paritytech-processbot paritytech-processbot bot deleted the revert-libp2p-0.52 branch August 16, 2023 10:06
@mxinden
Copy link
Contributor

mxinden commented Aug 17, 2023

Let me know in case you need any help debugging the v0.52.1 issues you are seeing.

@altonen
Copy link
Contributor Author

altonen commented Aug 17, 2023

@mxinden cheers, I'll be in contact with you when I start working the upgrade again and if I can't figure out the issues.

Ank4n pushed a commit that referenced this pull request Aug 20, 2023
* Revert "chore: update libp2p to 0.52.1 (#14429)"

This reverts commit d38d176.

* Fix dependencies

* Update dependencies

* Update Cargo.lock
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants