Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add discord invite to contributing doc #14674

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Add discord invite to contributing doc #14674

merged 4 commits into from
Jul 29, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jul 28, 2023

Changes:

  • Convert CONTRIBUTING from adoc to markdown.
  • Add Discord badge to CONTRIBUTING.md.

Can we add a direct channel invite link here? Not sure how Discord is normally used.

@ggwpez
Rename file
4d2cf2c 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Convert to Markdown
12e4b02 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add discord badge
1d6627e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. I6-documentation Documentation needs fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 28, 2023
ggwpez
ggwpez commented Jul 28, 2023
View reviewed changes
docs/CONTRIBUTING.md
Comment on lines +5 to +6
Contributors are invited to our `#frame-contributors` channel on the Polkadot Discord for support and coordination:
[![Discord](https://img.shields.io/discord/722223075629727774?style=for-the-badge&logo=discord&label=Discord)](https://dot.li/discord)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we bring back a channel that we deprecated a year ago and then we also do this on discord...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its for making the external FRAME contributors feel more included for getting hints about their issues and coordination.
All technical Qs will still be redirected to SE etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still be an element channel with a bridge to discord :P

franciscoaguirre
franciscoaguirre approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@franciscoaguirre franciscoaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

kianenigma
kianenigma approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking it a step further, we can also add it here https://paritytech.github.io/ cc @wentelteefje

@gilescope
Copy link
Contributor

Fine with it but once we merge we will need to fixup the broken links: https://github.com/search?q=org%3Aparitytech%20CONTRIBUTING.adoc&type=code

@ggwpez
Fix links
59c8e21 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Jul 29, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit c4b83fa into master Jul 29, 2023
3 checks passed
@paritytech-processbot paritytech-processbot bot deleted the oty-contrib-docs branch July 29, 2023 13:34
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr left review comments

@gpestana gpestana gpestana approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@kianenigma kianenigma kianenigma approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I6-documentation Documentation needs fixing, improving or augmenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ggwpez @gilescope @gpestana @franciscoaguirre @kianenigma @bkchr @liamaharon