Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

use Toggle instead of Option for mdns #14667

Merged
merged 1 commit into from
Jul 31, 2023
Merged

use Toggle instead of Option for mdns #14667

merged 1 commit into from
Jul 31, 2023

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jul 28, 2023

@melekes melekes requested a review from a team July 28, 2023 06:54
@melekes melekes self-assigned this Jul 28, 2023
@melekes melekes added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 28, 2023
@melekes melekes requested a review from kpp July 28, 2023 06:55
@michalkucharczyk michalkucharczyk requested a review from a team July 28, 2023 07:09
@altonen altonen added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jul 28, 2023
@melekes
Copy link
Contributor Author

melekes commented Jul 31, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1d13511 into paritytech:master Jul 31, 2023
17 of 18 checks passed
@melekes melekes deleted the anton/mdns-toggle branch July 31, 2023 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@skunert skunert skunert approved these changes

@davxy davxy davxy approved these changes

@altonen altonen altonen approved these changes

@kpp kpp Awaiting requested review from kpp

Assignees

@melekes melekes

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Networking
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@melekes @michalkucharczyk @skunert @davxy @altonen