chainHead_storage: Backport queries for value types #14551

lexnv · 2023-07-11T16:56:25Z

This PR backports the following RPC V2 spec changes for chainHead_storage:

Add a new Storage event since the ChainHeadEvent::Done has diverged
Test serialization/deserialization for both the added events and input parameters to the method
Allow users to fetch initially the value similarly as before
Adjust testing to reflect the new API

Closes: #14547

// @paritytech/subxt-team

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

…ue_hash

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

client/rpc-spec-v2/src/chain_head/api.rs

client/rpc-spec-v2/src/chain_head/event.rs

client/rpc-spec-v2/src/chain_head/chain_head_storage.rs

client/rpc-spec-v2/src/chain_head/error.rs

client/rpc-spec-v2/src/chain_head/chain_head_storage.rs

skunert · 2023-07-18T15:00:48Z

client/rpc-spec-v2/src/chain_head/chain_head_storage.rs

+			match result {
+				QueryResult::Buffered(storage_result) => storage_results.push(storage_result),
+				QueryResult::Immediate(event) => {
+					let _ = sink.send(&event);


The spec says this about errors: "This can only be the first event generated by this subscription. No other event will be generated with this subscription.". As far as I see we continue to send events here even after some error was sent.

Thanks for pointing this out! I opened paritytech/json-rpc-interface-spec#63 in the spec to ask for some clarifications here, since we could have multiple items in the query we might still want to return the Error after processing and sending some results back to the user

Oki doki, have made the error event here the first event and only event submitted.
No more events would be produced now after we encounter an error here

I've opened paritytech/json-rpc-interface-spec#63 for further discussion about intermediate error events.

In the meanwhile, to make some progress here we'll stick with today's version of the spec
Thanks!

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Co-authored-by: Sebastian Kunert <skunert49@gmail.com>

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

… lexnv/rpc_query_value_hash

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

skunert

Looks good!

client/rpc-spec-v2/src/chain_head/api.rs

client/rpc-spec-v2/src/chain_head/event.rs

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

jsdw

Looks good to me from what I understand!

* chainHead/events: Add storage params and events Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/tests: Check storage events serialization / deserialization Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/error: Add error for invalid WaitForContinue storage call Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/storage: Use new items params Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/tests: Adjust storage tests to the new API Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/events: Generalize StorageQuery by provided key Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chain_head: Add dedicated ChainHeadStorage client for queries Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/storage: Implement queries for hashes of values Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/tests: Check storage queries for hashes of values Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead: Improve API documentation wrt multiple entries Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead/event: Rename StorageQueue ty to queue_ty Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chianHead: Add helper to encode chainHead results as hex str Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update client/rpc-spec-v2/src/chain_head/error.rs Co-authored-by: Sebastian Kunert <skunert49@gmail.com> * chainHead: Change the `queryResult` to a plain `Result` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead: Stop producing events after the first error Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * chainHead: Change child_key to child_trie API param Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Sebastian Kunert <skunert49@gmail.com>

lexnv added 5 commits July 11, 2023 16:50

chainHead/events: Add storage params and events

8627f52

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chainHead/tests: Check storage events serialization / deserialization

cf53118

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chainHead/error: Add error for invalid WaitForContinue storage call

14cdb00

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chainHead/storage: Use new items params

2b3bbc8

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chainHead/tests: Adjust storage tests to the new API

684865e

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv self-assigned this Jul 11, 2023

lexnv added 3 commits July 12, 2023 11:48

Merge remote-tracking branch 'origin/master' into lexnv/rpc_query_val…

8c78395

…ue_hash

chainHead/events: Generalize StorageQuery by provided key

9499f42

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chain_head: Add dedicated ChainHeadStorage client for queries

9379e3c

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

bkchr requested a review from skunert July 13, 2023 13:19

lexnv added 2 commits July 13, 2023 19:22

chainHead/storage: Implement queries for hashes of values

4c57700

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chainHead/tests: Check storage queries for hashes of values

25d9dd1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

skunert reviewed Jul 18, 2023

View reviewed changes

lexnv and others added 4 commits July 19, 2023 14:33

chainHead: Improve API documentation wrt multiple entries

2de59ea

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chainHead/event: Rename StorageQueue ty to queue_ty

bcee42a

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

chianHead: Add helper to encode chainHead results as hex str

bb364e4

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Update client/rpc-spec-v2/src/chain_head/error.rs

a5563a0

Co-authored-by: Sebastian Kunert <skunert49@gmail.com>

lexnv mentioned this pull request Jul 19, 2023

chainHead_storage: Extend reported error events paritytech/json-rpc-interface-spec#63

Closed

lexnv added 3 commits July 19, 2023 15:27

chainHead: Change the queryResult to a plain Result

1a8bda3

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/lexnv/rpc_query_value_hash' into…

2447fea

… lexnv/rpc_query_value_hash

chainHead: Stop producing events after the first error

18b7b37

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

skunert approved these changes Jul 20, 2023

View reviewed changes

jsdw reviewed Jul 20, 2023

View reviewed changes

client/rpc-spec-v2/src/chain_head/api.rs Outdated Show resolved Hide resolved

jsdw reviewed Jul 20, 2023

View reviewed changes

client/rpc-spec-v2/src/chain_head/event.rs Show resolved Hide resolved

chainHead: Change child_key to child_trie API param

09f8666

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

jsdw approved these changes Jul 21, 2023

View reviewed changes

lexnv merged commit 750fa6b into master Jul 21, 2023
7 checks passed

lexnv deleted the lexnv/rpc_query_value_hash branch July 21, 2023 16:56

lexnv mentioned this pull request Jul 24, 2023

Subxt integration tests failed against latest Substrate build. paritytech/subxt#1081

Closed

crystalin mentioned this pull request Oct 20, 2023

Update substrate/polkadot/cumulus from v0.9.43 to v1.1.0 moonbeam-foundation/moonbeam#2535

Closed

JesseAbram mentioned this pull request Oct 26, 2023

Update substrate and subxt entropyxyz/entropy-core#435

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chainHead_storage: Backport queries for value types #14551

chainHead_storage: Backport queries for value types #14551

lexnv commented Jul 11, 2023 •

edited

Loading

skunert Jul 18, 2023

lexnv Jul 19, 2023

lexnv Jul 20, 2023 •

edited

Loading

skunert left a comment

jsdw left a comment

chainHead_storage: Backport queries for value types #14551

chainHead_storage: Backport queries for value types #14551

Conversation

lexnv commented Jul 11, 2023 • edited Loading

skunert Jul 18, 2023

Choose a reason for hiding this comment

lexnv Jul 19, 2023

Choose a reason for hiding this comment

lexnv Jul 20, 2023 • edited Loading

Choose a reason for hiding this comment

skunert left a comment

Choose a reason for hiding this comment

jsdw left a comment

Choose a reason for hiding this comment

lexnv commented Jul 11, 2023 •

edited

Loading

lexnv Jul 20, 2023 •

edited

Loading