Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Cleanup dependencies #14464

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Cleanup dependencies #14464

merged 3 commits into from
Jun 27, 2023

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Jun 26, 2023 •
edited
Loading

Removal of unused dependencies.

Polkadot companion: paritytech/polkadot#7429

@skunert skunert added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”. labels Jun 26, 2023
@skunert skunert requested review from a team June 26, 2023 15:16
@skunert skunert mentioned this pull request Jun 26, 2023
Merged
ggwpez
ggwpez approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

kianenigma
kianenigma approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tool did you use? i recently used cargo-machete and works quite well in FRAME as well (cargo-machete --with-metadata).

@skunert
Copy link
Contributor Author

skunert commented Jun 27, 2023

What tool did you use? i recently used cargo-machete and works quite well in FRAME as well (cargo-machete --with-metadata).

I also used cargo-machete for this. There were some false positives, but overall worked reasonably well 👍

@skunert
Copy link
Contributor Author

skunert commented Jun 27, 2023

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/polkadot#7429

@koute
Copy link
Contributor

koute commented Jun 27, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1724153 into paritytech:master Jun 27, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@skunert @nathanwhit
Remove unused dependencies (paritytech#14464)
21de73d
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koute koute koute approved these changes

@gpestana gpestana gpestana approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

@davxy davxy davxy approved these changes

@ggwpez ggwpez ggwpez approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
SDK Node
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@skunert @koute @gpestana @kianenigma @bkchr @davxy @ggwpez