This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Pallets: Treasury spends various asset kinds #14434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bfccac0.
muharem
changed the title
1 task
muharem
added
A3-in_progress
muharem
added
the
F3-breaks_API
muharem
commented
Jul 10, 2023
| @@ -15,53 +15,69 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| //! > Made with *Substrate*, for *Polkadot*. | |||
There was a problem hiding this comment.
updated according to the guidelines https://github.com/paritytech/substrate/blob/master/docs/DOCUMENTATION_GUIDELINES.md#pallet-crates
5 tasks
joepetrowski
approved these changes
Jul 20, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
bot rebase |
|
Rebased |
|
bot rebase |
|
Rebased |
gavofyork
reviewed
Aug 1, 2023
| let native_amount = T::BalanceConverter::from_asset_balance(amount, asset_kind.clone()) | ||
| .map_err(|_| Error::<T, I>::FailedToConvertBalance)?; | ||
|
|
||
| ensure!(native_amount <= max_amount, Error::<T, I>::InsufficientPermission); |
There was a problem hiding this comment.
is this not superfluous with the next block in place?
There was a problem hiding this comment.
now it runs with context only if dispatched via UnfilteredDispatchable::dispatch_bypass_filter
gavofyork
approved these changes
Aug 1, 2023
sam0x17
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treasury Pallet can accept proposals for
spendsof variousasset kindsand pay them out through the implementation of thePaytrait.New Dispatchables:
The parameters' types of the
spenddispatchable exposed via the pallet'sConfigand allows to propose and accept a spend of a certain amount.An approved spend can be claimed via the
payoutwithin theConfig::SpendPeriod. Clients provide an implementation of thePaytrait which can pay an asset of theAssetKindto theBeneficiary.The implementation of the
Paytrait might not have an immediate final payment status, for example if implemented over XCM and the actual transfer happens on a remote chain.The
check_statusdispatchable can be executed to update the spend's payment state and retry thepayoutif the payment has failed.polkadot companion: paritytech/polkadot#7427
Closes paritytech/polkadot-sdk#92