Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

expose setting kademlia replication factor through node CLI #14391

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

klbrvik
Copy link
Contributor

@klbrvik klbrvik commented Jun 15, 2023

What does it do?

Exposes setting Kademlia replication factor through node's CLI.

Why?

Default Kademlia replication factor is 20. In environments (testing for example) with less than 20 nodes AuthorityDiscovery fails to publish DHT records containing node's Multiaddrs. So to make AuthorityDiscovery work in test environments it's useful to have option to manually adjust Kademlia replication factor.

@altonen altonen added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels Jun 15, 2023
@altonen altonen requested a review from a team June 15, 2023 07:17
client/network/src/config.rs Outdated Show resolved Hide resolved
@klbrvik klbrvik marked this pull request as ready for review June 15, 2023 09:58
@bkchr bkchr merged commit fe1f8ba into paritytech:master Jun 21, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…ch#14391)

* expose kademlia replication factor through node CLI

* set default CLI flag value for kademlia_replication_factor

Co-authored-by: Bastian Köcher <git@kchr.de>

* wrap CLI value as Option

* make kademlia replication factor non-optional

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants