Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix(remote-externalities): child trie not loaded #14365

Merged
merged 3 commits into from
Jun 21, 2023
Merged

fix(remote-externalities): child trie not loaded #14365

merged 3 commits into from
Jun 21, 2023

Conversation

liamaharon
Copy link
Contributor

Should close #14151

Fixes a regression that was introduced during one of my refactors causing rpc_get_pairs_paged to filter out child keys from its return value, which in turn caused load_child_remote to not be passed any child root keys to load.

@cheme I've tested this and it seems to be working, could you please also confirm?

@liamaharon liamaharon added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 13, 2023
@liamaharon liamaharon requested review from cheme and kianenigma June 13, 2023 11:22
cheme
cheme approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liamaharon liamaharon removed the request for review from kianenigma June 20, 2023 07:49
kianenigma
kianenigma approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test would be nice to make sure this won't regress again 🙈

@liamaharon
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 3413493 into master Jun 21, 2023
@paritytech-processbot paritytech-processbot bot deleted the liam-fix-remote-ext-child-keys branch June 21, 2023 14:16
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@liamaharon @nathanwhit
fix(remote-externalities): child trie not loaded (paritytech#14365)
c69d0bb 
* fix remote-ext chlid keys

* sanity check test that child trie is loaded
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre left review comments

@cheme cheme cheme approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Child trie not included when exporting a snapshot
5 participants
@liamaharon @cheme @franciscoaguirre @kianenigma @bkchr