This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
migration(democracy): unreserve deposits and clear locks #14226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
12 tasks
liamaharon
changed the title
liamaharon
changed the title
liamaharon
added
A0-please_review
|
I just found a way to handle the Balances types cleaner. Switching this to a draft while I improve that, also going to add some unit tests. |
liamaharon
added
A3-in_progress
liamaharon
added
A0-please_review
ggwpez
reviewed
Jun 13, 2023
frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs
Outdated
Show resolved
Hide resolved
frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs
Outdated
Show resolved
Hide resolved
frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs
Outdated
Show resolved
Hide resolved
frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
Jun 13, 2023
frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs
Outdated
Show resolved
Hide resolved
kianenigma
approved these changes
Jun 13, 2023
kianenigma
reviewed
Jun 13, 2023
sam0x17
approved these changes
Jun 13, 2023
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
…mocracy-unreserve-funds
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
…h/substrate into liam-democracy-unreserve-funds
|
bot merge |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…14226) * unlock and unreserve all migration * log total amount to unlock * clippy * clippy * simplify balance types * add tests * fix comment * fix std features * remove redundant dev-dep * address comments * remove redundant std * estimate weights * fix comments * fix tests * clippy * track democracy bugged deposits * improve pre_migration logs * oliver comments from tips pr * run pre and post hooks in tests * flexible dbweight type * Update frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * docs * Update frame/democracy/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * add log target * fix visibility * lint * use log target --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial paritytech/polkadot-sdk#485
Overview
Adds a migration that unreserves all deposits and clears locks held by the
democracypallet.I've verified this works using
try-runtime-cliand the latest Polkadot state (testing with Kusama state blocked by my last Q below).Details
democracycontains aDepositOfstorage item containing all the amounts reserved by this pallet, and aVotersstorage item containing all the accounts that have locks held in the context of this pallet.pre_upgradecollects pre-migration data useful for validating the migration was successful, and also checks the integrity of deposited balances.on_runtime_upgradeunreserves and unlocks the balances.post_upgradechecks that no more locks exist for the pallet, and reserved balances were reduced by the expected amount.try-runtime-clion-runtime-upgradelogsQuestions for reviewers / todos:
This currently assumes that thedemocracypallet is part of the runtime. We need to run it for Kusama where it has already been removed from the runtime. What's the cleanest way to go about this?How do I calculate the weight of theremove_lockandunreservecalls?remove_locktriggers someERROR main runtime::system: Logic error: Unexpected underflow in reducing consumererror logs. I have verified that a non-zero lock always exists beforeremove_lockis called, even when it results in this log. Are they safe to ignore?