Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Easy PR: Fix warnings from latest nightly #14195

Merged
merged 3 commits into from
May 23, 2023
Merged

Easy PR: Fix warnings from latest nightly #14195

merged 3 commits into from
May 23, 2023

Conversation

gilescope
Copy link
Contributor

Unneeded muts removed.

Removed needless .borrow()s. (Two seemed to be needed so these I switched to just use an &)

Now compiles without warnings on latest nightly.

@gilescope gilescope added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 23, 2023
@gilescope gilescope requested review from a team, bkchr, ggwpez and kianenigma May 23, 2023 09:46
@bkchr
Copy link
Member

bkchr commented May 23, 2023

Requires master merge.

@bkchr
Copy link
Member

bkchr commented May 23, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 3e504d6

@bkchr bkchr merged commit 32ab5cb into master May 23, 2023
@bkchr bkchr deleted the giles-fix-warnings branch May 23, 2023 15:06
gpestana pushed a commit that referenced this pull request May 27, 2023
* unneeded mut

* remove needless borrows
Ank4n pushed a commit that referenced this pull request Jul 8, 2023
* unneeded mut

* remove needless borrows
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* unneeded mut

* remove needless borrows
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants