Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

test-runtime: Return hashed call as provides in unsigned validation #14180

Merged
merged 1 commit into from
May 22, 2023
Merged

test-runtime: Return hashed call as provides in unsigned validation #14180

merged 1 commit into from
May 22, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 19, 2023

This is required to make different unsigned extrinsics resolve to different transactions in the tx pool by having provides set to the hash of the call.

@bkchr
test-runtime: Return hashed call as provides in unsigned validation
c832fd1 
This is required to make different unsigned extrinsics resolve to different transactions in the tx
pool by having `provides` set to theh hash of the call.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 19, 2023
@bkchr bkchr requested a review from a team May 19, 2023 22:22
@michalkucharczyk michalkucharczyk requested a review from a team May 20, 2023 06:07
@bkchr bkchr merged commit 17a99d1 into master May 22, 2023
@bkchr bkchr deleted the bkchr-test-runtime-unsigned-validate branch May 22, 2023 08:51
gpestana pushed a commit that referenced this pull request May 27, 2023
@bkchr @gpestana
test-runtime: Return hashed call as provides in unsigned validation (#…
44ee5a9 
…14180)

This is required to make different unsigned extrinsics resolve to different transactions in the tx
pool by having `provides` set to theh hash of the call.
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@bkchr @nathanwhit
test-runtime: Return hashed call as provides in unsigned validation (p…
d8dd817 
…aritytech#14180)

This is required to make different unsigned extrinsics resolve to different transactions in the tx
pool by having `provides` set to theh hash of the call.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@skunert skunert skunert approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @michalkucharczyk @skunert