Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move node-template Cargo.toml dependencies to workspace #14058

Merged
merged 4 commits into from
May 16, 2023

Conversation

kalaninja
Copy link
Contributor

Updates node-template-release tool to collect git dependencies of node-template modules and puts them into [workspace.dependencies] of root Cargo.toml.

@kalaninja kalaninja requested a review from a team as a code owner May 1, 2023 13:55
@kalaninja kalaninja force-pushed the master branch 2 times, most recently from 42f609f to 75d0eef Compare May 2, 2023 11:45
scripts/ci/node-template-release/src/main.rs Outdated Show resolved Hide resolved
scripts/ci/node-template-release/src/main.rs Outdated Show resolved Hide resolved
scripts/ci/node-template-release/src/main.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from ggwpez May 3, 2023 20:52
tar = "0.4"
tempfile = "3"
toml = "0.4"
toml_edit = "0.19"
itertools = "0.10"

[workspace]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line removed in #14103

@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels May 11, 2023
kalaninja and others added 2 commits May 11, 2023 21:35
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr bkchr merged commit dd478bc into paritytech:master May 16, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…4058)

* Move node-template Cargo.toml dependencies to workspace

* review

* Update Cargo.lock

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants