Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Warn if pallet provided to try-state does not exist #13858

Merged
merged 3 commits into from
Apr 8, 2023

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Apr 8, 2023

Currently, we are not providing users with a warning message on the try-state subcommand of the try-runtime CLI when they provide a pallet that is not implemented in the runtime.

This PR resolves the issue by adding a warning log.

@liamaharon liamaharon self-requested a review April 8, 2023 14:45
@liamaharon liamaharon added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Apr 8, 2023
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@liamaharon
Copy link
Contributor

@Szegoo could you please pull origin master into this branch?

@liamaharon liamaharon merged commit 82e824b into paritytech:master Apr 8, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Warn if pallet does not exist in try-state

* unwrap_or_default
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants