-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add HoldReason to the NIS pallet #13823
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ pub fn expand_outer_freeze_reason(pallet_decls: &[Pallet], scrate: &TokenStream) | |
} | ||
|
||
quote! { | ||
/// A reason for placing a freeze on funds. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be better to forward the real docs put on top of the type? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't that what this is already doing? It's documenting a type that is expanded by the proc macro. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't forwarding the docs that I as a user put onto the type? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah okay, so the problem is that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahh okay, missed that this is the runtime level declaration. |
||
#[derive( | ||
Copy, Clone, Eq, PartialEq, Ord, PartialOrd, | ||
#scrate::codec::Encode, #scrate::codec::Decode, #scrate::codec::MaxEncodedLen, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, but it's there to ensure that the codec index remains unchanged by being explicit.