This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use proper weights in the pallet-template
#13817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD10S
added
the
A3-in_progress
ggwpez
reviewed
Apr 4, 2023
ggwpez
approved these changes
Apr 4, 2023
| @@ -20,6 +20,7 @@ scale-info = { version = "2.1.1", default-features = false, features = ["derive" | |||
| frame-benchmarking = { version = "4.0.0-dev", default-features = false, optional = true, path = "../../../../frame/benchmarking" } | |||
| frame-support = { version = "4.0.0-dev", default-features = false, path = "../../../../frame/support" } | |||
| frame-system = { version = "4.0.0-dev", default-features = false, path = "../../../../frame/system" } | |||
| sp-std = { version = "5.0.0", default-features = false, path = "../../../../primitives/std" } | |||
There was a problem hiding this comment.
You just found yourself another issue (if you want obviously 😛).
Getting rid of this and using PhantomData from core::marker instead.
|
FYI you can auto-close the mentioned issue once this merges https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
ggwpez
added
A0-please_review
|
Can you still make the CI green please? |
kianenigma
approved these changes
Apr 5, 2023
gpestana
approved these changes
Apr 5, 2023
sam0x17
approved these changes
Apr 5, 2023
KiChjang
approved these changes
Apr 5, 2023
|
bot merge |
paritytech-processbot
bot
deleted the
alexd10s-use-proper-weights-pallet-template
branch
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
* benchmarking to generate weights file * add the calculated weights in the extrinsics * use benchmarking v2 syntax to generate the weights * minor syntax change when benchmarking * added WeightInfo in the mock to pass tests * minor cargo fmt format changes
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* benchmarking to generate weights file * add the calculated weights in the extrinsics * use benchmarking v2 syntax to generate the weights * minor syntax change when benchmarking * added WeightInfo in the mock to pass tests * minor cargo fmt format changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #13761 - Use proper weights in the
pallet-template.Part of the issue paritytech/polkadot-sdk#192