This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Keystore overhaul (iter 2) #13634
Merged
Keystore overhaul (iter 2) #13634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2023
davxy
added
A0-please_review
davxy
requested review from
bkchr,
acatangiu,
melekes and
a team
and removed request for
andresilva
acatangiu
approved these changes
Mar 18, 2023
skunert
approved these changes
Mar 19, 2023
bkchr
approved these changes
Mar 19, 2023
sandreim
approved these changes
Mar 20, 2023
|
bot merge |
|
Waiting for commit status. |
1 task
breathx
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 22, 2023
* Remove bloat about remote keystore * Update docs and remove unused 'KeystoreRef' trait * Use wherever possible, MemoryKeystore for testing * Remove unrequired fully qualified method syntax for Keystore
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Remove bloat about remote keystore * Update docs and remove unused 'KeystoreRef' trait * Use wherever possible, MemoryKeystore for testing * Remove unrequired fully qualified method syntax for Keystore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #13556
This PR is part of a small overhaul of the keystore related traits and structures.
Within this PR:
polkadot companion: paritytech/polkadot#6913
cumulus companion: paritytech/cumulus#2345