This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
consensus: remove caching functionality from block import pipeline #13551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
andresilva
added a commit
to paritytech/cumulus
that referenced
this pull request
Mar 6, 2023
bkchr
approved these changes
Mar 6, 2023
koute
approved these changes
Mar 7, 2023
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/cumulus#2278 |
|
Need another approval on the cumulus companion. |
|
bot merge |
paritytech-processbot
bot
deleted the
andre/cleanup-block-import-verifier
branch
paritytech-processbot bot
pushed a commit
to paritytech/cumulus
that referenced
this pull request
Mar 7, 2023
* Companion for paritytech/substrate#13551 * update lockfile for {"substrate", "polkadot"} --------- Co-authored-by: parity-processbot <>
1 task
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
…aritytech#13551) * consensus: remove caching functionality from block import pipeline * client: update docs on Verifier::verify * node: fix block production benchmark
6 tasks
15 tasks
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 13, 2023
* Companion for paritytech/substrate#13551 * update lockfile for {"substrate", "polkadot"} --------- Co-authored-by: parity-processbot <>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…aritytech#13551) * consensus: remove caching functionality from block import pipeline * client: update docs on Verifier::verify * node: fix block production benchmark
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block-import pipeline included functionality to maintain a cache that was passed to
BlockImport::import_block, additionally it was possible to add/update entries in this cache as part of the initial block verification process (i.e.trait Verifier). This functionality was previously used by the light client in order to cache data that was fetched from the runtime (since the light client cannot execute the runtime fetching this data requires network requests), namely the current authorities. Substrate no longer provides a light client and therefore this is now completely unused. This PR removes this caching functionality. It is still possible to pass data along the block-import pipeline (e.g. from verifier to block import) through the use of intermediates (inBlockImportParams).cumulus companion: paritytech/cumulus#2278