Add amalgamation traits for NFT CollectionId and ItemId #13514

jasl · 2023-03-02T15:47:25Z

I don't know this is the right direction but I believe this would help when people interacting with NFT traits return values in their own pallets

Basically I'm imitating how fungible traits does

Background:
I'm learning NFTs pallet so I'm building my own pallet that invoking pallet_nfts via nonfungibles_v2 interface,
I tried:

Create collections in my pallet and deposit an event
Mint items in my pallet

then, I found few problems:

create_collection returns collection_id but can't be used in event's payload because the trait `Clone` is not implemented for `<<T as pallet::Config>::NonFungibles as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId
mint_into requires ItemConfig but it can be constructed out of pallet_nfts

and a question:

How to construct CollectionId and ItemId from a 3rd pallet?

jasl · 2023-03-02T16:55:58Z

Add a non topic change (perhaps I need update the title?)

jasl · 2023-03-02T20:26:44Z

@jsidorenko Could you help to take a look? (don't know how to assign reviewers...)

jsidorenko · 2023-03-03T12:44:55Z

Hey @jasl ,

How to construct CollectionId and ItemId from a 3rd pallet?

Could you pls provide some code snippet or push your code to GH and put a link here?
I don't quite understand the problem you're facing when constructing the ItemId, won't the 1234u32.into() do the magic?

jasl · 2023-03-03T13:30:51Z

Hey @jasl ,

How to construct CollectionId and ItemId from a 3rd pallet?

Could you pls provide some code snippet or push your code to GH and put a link here?

I don't quite understand the problem you're facing when constructing the ItemId, won't the 1234u32.into() do the magic?

I remeber I tried but not work,
I'll re-check and make a public repo for you if not works

jasl · 2023-03-03T19:10:24Z

Hey @jasl ,

How to construct CollectionId and ItemId from a 3rd pallet?

Could you pls provide some code snippet or push your code to GH and put a link here? I don't quite understand the problem you're facing when constructing the ItemId, won't the 1234u32.into() do the magic?

I pushed minimal reproducible code

Background:
I'm trying to build a pallet to work with pallet_nft,
my goal is disable most of pallet_nfts extrinsic and my pallet will help to management collection, minting nfts and update them, users can only own and burn NFTs, rest of other operations are restricted.

version 1: https://github.com/jasl/learn_nft/blob/main/src/lib.rs
my pallet extending pallet_nft (relates to #13517 )

error[E0603]: type alias `NextCollectionId` is private
   --> src/lib.rs:116:18
    |
116 |                 pallet_nfts::NextCollectionId::<T, I>::get().unwrap_or(CollectionIdOf::<T, I>::initial_value());
    |                              ^^^^^^^^^^^^^^^^ private type alias
    |
note: the type alias `NextCollectionId` is defined here
   --> /Users/jasl/.cargo/git/checkouts/substrate-7e08433d4c370a21/2cb4825/frame/nfts/src/lib.rs:59:9
    |
59  | pub use pallet::*;
    |         ^^^^^^^^^

error[E0277]: the trait bound `<T as pallet_nfts::Config<I>>::ItemId: From<u32>` is not satisfied
   --> src/lib.rs:147:10
    |
147 |                 0u32.into(),
    |                      ^^^^ the trait `From<u32>` is not implemented for `<T as pallet_nfts::Config<I>>::ItemId`
    |
    = note: required for `u32` to implement `Into<<T as pallet_nfts::Config<I>>::ItemId>`
help: consider further restricting the associated type
    |
135 |         ) -> DispatchResult where <T as pallet_nfts::Config<I>>::ItemId: From<u32> {
    |                             ++++++++++++++++++++++++++++++++++++++++++++++++++++++

Some errors have detailed explanations: E0277, E0603.
For more information about an error, try `rustc --explain E0277`.

version 2: https://github.com/jasl/learn_nft/blob/another-case/src/lib.rs
use nonfungibles_v2 trait

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: Clone` is not satisfied
  --> src/lib.rs:83:42
   |
83 |         CollectionCreated { who: T::AccountId, collection_id: CollectionIdOf<T> },
   |                                                ^^^^^^^^^^^^^ the trait `Clone` is not implemented for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`

error[E0369]: binary operation `==` cannot be applied to type `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
  --> src/lib.rs:83:42
   |
83 |         CollectionCreated { who: T::AccountId, collection_id: CollectionIdOf<T> },
   |                                                ^^^^^^^^^^^^^

error[E0277]: `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` doesn't implement `std::fmt::Debug`
  --> src/lib.rs:83:42
   |
83 |         CollectionCreated { who: T::AccountId, collection_id: CollectionIdOf<T> },
   |                                                ^^^^^^^^^^^^^ `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
   |
   = help: the trait `std::fmt::Debug` is not implemented for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
   = note: required for `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `std::fmt::Debug`
   = note: required for the cast from `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to the object type `dyn std::fmt::Debug`

error[E0277]: the trait bound `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::ItemId: From<u32>` is not satisfied
   --> src/lib.rs:145:10
    |
145 |                 1u32.into(),
    |                      ^^^^ the trait `From<u32>` is not implemented for `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::ItemId`
    |
    = note: required for `u32` to implement `Into<&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::ItemId>`

error[E0308]: mismatched types
   --> src/lib.rs:144:5
    |
143 |             T::NFTCollection::mint_into(
    |             --------------------------- arguments to this function are incorrect
144 |                 collection,
    |                 ^^^^^^^^^^
    |                 |
    |                 expected `&<... as Inspect<...>>::CollectionId`, found associated type
    |                 help: consider borrowing here: `&collection`
    |
    = note:    expected reference `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
            found associated type `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    = help: consider constraining the associated type `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    = note: for more information, visit https://doc.rust-lang.org/book/ch19-03-advanced-traits.html
note: associated function defined here
   --> /Users/jasl/.cargo/git/checkouts/substrate-7e08433d4c370a21/2cb4825/frame/support/src/traits/tokens/nonfungibles_v2.rs:224:5
    |
224 |     fn mint_into(
    |        ^^^^^^^^^

error[E0277]: `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` doesn't implement `std::fmt::Debug`
   --> src/lib.rs:136:4
    |
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^ `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    = note: required for `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `std::fmt::Debug`
    = note: required for the cast from `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to the object type `dyn std::fmt::Debug`

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: Clone` is not satisfied
   --> src/lib.rs:136:4
    |
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^ the trait `Clone` is not implemented for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`

error[E0369]: binary operation `==` cannot be applied to type `&<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
   --> src/lib.rs:136:4
    |
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: WrapperTypeEncode` is not satisfied
   --> src/lib.rs:136:4
    |
52  | #[frame_support::pallet]
    | ------------------------ required by a bound introduced by this call
...
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^ the trait `WrapperTypeEncode` is not implemented for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    |
    = note: required for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `parity_scale_codec::Encode`

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: WrapperTypeDecode` is not satisfied
   --> src/lib.rs:93:12
    |
93  |       #[pallet::call]
    |  _______________^
94  | |     impl<T: Config> Pallet<T> {
95  | |         #[pallet::call_index(0)]
96  | |         #[pallet::weight(0)]
...   |
135 | |             origin: OriginFor<T>,
136 | |             collection: CollectionIdOf<T>
    | |_________________________________________^ the trait `WrapperTypeDecode` is not implemented for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    |
    = note: required for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `Decode`

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: TypeInfo` is not satisfied
   --> src/lib.rs:93:12
    |
93  |     #[pallet::call]
    |               ^^^^ the trait `TypeInfo` is not implemented for `<<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    |
note: required for `pallet::Call<T>` to implement `TypeInfo`
   --> src/lib.rs:52:1
    |
52  | #[frame_support::pallet]
    | ^^^^^^^^^^^^^^^^^^^^^^^^ unsatisfied trait bound introduced in this `derive` macro
...
93  |     #[pallet::call]
    |               ^^^^
note: required by a bound in `meta_type`
   --> /Users/jasl/.cargo/registry/src/github.com-1ecc6299db9ec823/scale-info-2.3.1/src/lib.rs:394:17
    |
394 |     T: ?Sized + TypeInfo + 'static,
    |                 ^^^^^^^^ required by this bound in `meta_type`
    = note: this error originates in the derive macro `frame_support::scale_info::TypeInfo` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider further restricting the associated type
    |
93  |     #[pallet::call where <<T as pallet::Config>::NFTCollection as frame_support::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: TypeInfo]
    |                    +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Some errors have detailed explanations: E0277, E0308, E0369.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `pallet-nft_computing` due to 11 previous errors
warning: build failed, waiting for other jobs to finish...
error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: Clone` is not satisfied
  --> src/lib.rs:83:42
   |
83 |         CollectionCreated { who: T::AccountId, collection_id: CollectionIdOf<T> },
   |                                                ^^^^^^^^^^^^^ the trait `Clone` is not implemented for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`

error[E0369]: binary operation `==` cannot be applied to type `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
  --> src/lib.rs:83:42
   |
83 |         CollectionCreated { who: T::AccountId, collection_id: CollectionIdOf<T> },
   |                                                ^^^^^^^^^^^^^

error[E0277]: `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` doesn't implement `std::fmt::Debug`
  --> src/lib.rs:83:42
   |
83 |         CollectionCreated { who: T::AccountId, collection_id: CollectionIdOf<T> },
   |                                                ^^^^^^^^^^^^^ `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
   |
   = help: the trait `std::fmt::Debug` is not implemented for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
   = note: required for `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `std::fmt::Debug`
   = note: required for the cast from `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to the object type `dyn std::fmt::Debug`

error[E0277]: the trait bound `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::ItemId: From<u32>` is not satisfied
   --> src/lib.rs:145:10
    |
145 |                 1u32.into(),
    |                      ^^^^ the trait `From<u32>` is not implemented for `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::ItemId`
    |
    = note: required for `u32` to implement `Into<&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::ItemId>`

error[E0308]: mismatched types
   --> src/lib.rs:144:5
    |
143 |             T::NFTCollection::mint_into(
    |             --------------------------- arguments to this function are incorrect
144 |                 collection,
    |                 ^^^^^^^^^^
    |                 |
    |                 expected `&<... as Inspect<...>>::CollectionId`, found associated type
    |                 help: consider borrowing here: `&collection`
    |
    = note:    expected reference `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
            found associated type `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    = help: consider constraining the associated type `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    = note: for more information, visit https://doc.rust-lang.org/book/ch19-03-advanced-traits.html
note: associated function defined here
   --> /Users/jasl/.cargo/git/checkouts/substrate-7e08433d4c370a21/2cb4825/frame/support/src/traits/tokens/nonfungibles_v2.rs:224:5
    |
224 |     fn mint_into(
    |        ^^^^^^^^^

error[E0277]: `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` doesn't implement `std::fmt::Debug`
   --> src/lib.rs:136:4
    |
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^ `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    = note: required for `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `std::fmt::Debug`
    = note: required for the cast from `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to the object type `dyn std::fmt::Debug`

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: Clone` is not satisfied
   --> src/lib.rs:136:4
    |
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^ the trait `Clone` is not implemented for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`

error[E0369]: binary operation `==` cannot be applied to type `&<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
   --> src/lib.rs:136:4
    |
use nonfungibles_v2
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: WrapperTypeEncode` is not satisfied
   --> src/lib.rs:136:4
    |
52  | #[frame_support::pallet]
    | ------------------------ required by a bound introduced by this call
...
136 |             collection: CollectionIdOf<T>
    |             ^^^^^^^^^^ the trait `WrapperTypeEncode` is not implemented for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    |
    = note: required for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `parity_scale_codec::Encode`

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: WrapperTypeDecode` is not satisfied
   --> src/lib.rs:93:12
    |
93  |       #[pallet::call]
    |  _______________^
94  | |     impl<T: Config> Pallet<T> {
95  | |         #[pallet::call_index(0)]
96  | |         #[pallet::weight(0)]
...   |
135 | |             origin: OriginFor<T>,
136 | |             collection: CollectionIdOf<T>
    | |_________________________________________^ the trait `WrapperTypeDecode` is not implemented for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    |
    = note: required for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId` to implement `Decode`

error[E0277]: the trait bound `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: TypeInfo` is not satisfied
   --> src/lib.rs:93:12
    |
93  |     #[pallet::call]
    |               ^^^^ the trait `TypeInfo` is not implemented for `<<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId`
    |
note: required for `pallet::Call<T>` to implement `TypeInfo`
   --> src/lib.rs:52:1
    |
52  | #[frame_support::pallet]
    | ^^^^^^^^^^^^^^^^^^^^^^^^ unsatisfied trait bound introduced in this `derive` macro
...
93  |     #[pallet::call]
    |               ^^^^
note: required by a bound in `meta_type`
   --> /Users/jasl/.cargo/registry/src/github.com-1ecc6299db9ec823/scale-info-2.3.1/src/lib.rs:394:17
    |
394 |     T: ?Sized + TypeInfo + 'static,
    |                 ^^^^^^^^ required by this bound in `meta_type`
    = note: this error originates in the derive macro `frame_support::scale_info::TypeInfo` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider further restricting the associated type
    |
93  |     #[pallet::call where <<T as pallet::Config>::NFTCollection as hidden_include::traits::tokens::nonfungibles_v2::Inspect<<T as frame_system::Config>::AccountId>>::CollectionId: TypeInfo]
    |                    ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

error: could not compile `pallet-nft_computing` due to 11 previous errors

jsidorenko · 2023-03-09T09:32:19Z

Hi @jasl, I'm wondering why don't you want to connect the nfts pallet in a loosely coupled way?
Then you will be able to access the mint_into and create_collection methods. In the case of the create_collection(), you won't need to pass the collection id and deal with the NextCollectionId storage item.
You can find the example of connecting the pallet in this PR: #12565

jsidorenko · 2023-03-09T09:47:21Z

Sorry, I just checked the second example where you used the traits

jsidorenko · 2023-03-09T09:51:11Z

so, the item_id problem I was able able to solve locally by adding + From<u32> to type's definition in your pallet

jasl · 2023-03-09T09:53:01Z

Hi @jasl, I'm wondering why don't you want to connect the nfts pallet in a loosely coupled way? Then you will be able to access the mint_into and create_collection methods. In the case of the create_collection(), you won't need to pass the collection id and deal with the NextCollectionId storage item. You can find the example of connecting the pallet in this PR: #12565

My another case (https://github.com/jasl/learn_nft/blob/another-case/src/lib.rs) use that way, I'll learn from that PR first.

thank you

jsidorenko · 2023-03-09T10:13:25Z

@jasl regarding the Copy/Clone issue, I found it doesn't complain if you provide the ItemId/CollectionId via the runtime config: https://github.com/paritytech/substrate/pull/12565/files#diff-d757e0d131cebbebb0176e5448e53b54970ebb64f1c5d7f01537a4e221e587b0R175-R176

frame/support/src/traits/tokens/nonfungible_v2.rs

jasl · 2023-03-09T11:04:16Z

@jasl regarding the Copy/Clone issue, I found it doesn't complain if you provide the ItemId/CollectionId via the runtime config: https://github.com/paritytech/substrate/pull/12565/files#diff-d757e0d131cebbebb0176e5448e53b54970ebb64f1c5d7f01537a4e221e587b0R175-R176

I'll try this tonight, thank you for metion this.

bkchr

We don't need new traits for all of them, we can just use what is already there.

frame/support/src/traits/tokens/nonfungibles_v2.rs

frame/support/src/traits/tokens/nonfungible_v2.rs

frame/support/src/traits/tokens/misc.rs

jasl · 2023-03-09T14:59:15Z

I'll apply all Basti's suggests then squash them

jasl · 2023-03-09T15:01:33Z

@bkchr I basically follow how AssetId does, do you think AssetId (and maybe Balance) can apply this?

frame/support/src/traits/tokens.rs

jsidorenko · 2023-03-09T15:44:00Z

can you pls run cargo +nightly fmt?

bkchr · 2023-03-09T15:48:06Z

@bkchr I basically follow how AssetId does, do you think AssetId (and maybe Balance) can apply this?

Good questions :P IDK, I would need to check the code.

bkchr · 2023-03-09T15:48:14Z

bot fmt

command-bot · 2023-03-09T15:50:14Z

@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2504577 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 34-8516d894-46f0-48e0-8e8f-852b42384013 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-03-09T15:51:28Z

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2504577 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2504577/artifacts/download.

jsidorenko · 2023-03-09T16:14:36Z

P. S. @jasl I think we should simplify the collection's creation via traits and remove the config param.
If the advanced (non-default) settings are needed, they should be set via separate methods.
I've opened a PR for this today: #13572

jasl · 2023-03-09T16:15:43Z

#13572

GREAT! Thank you !
After this one merge, I'll refactor my code

jasl · 2023-03-09T17:23:45Z

@bkchr Could you help to merge this?

jsidorenko · 2023-03-09T17:44:14Z

bot merge

@bkchr

…3514) * Add amalgamation traits for NFT CollectionId, ItemId, and DestroyWitness * Apply @bkchr suggests * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <>

@bkchr

…3514) * Add amalgamation traits for NFT CollectionId, ItemId, and DestroyWitness * Apply @bkchr suggests * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <>

jasl force-pushed the amalgamation-traits-for-nft-types branch 2 times, most recently from 04fe4b8 to 9fdc72d Compare March 2, 2023 16:26

jasl mentioned this pull request Mar 2, 2023

Make pallet_nfts storages public #13517

Merged

jsidorenko reviewed Mar 9, 2023

View reviewed changes

frame/support/src/traits/tokens/nonfungible_v2.rs Outdated Show resolved Hide resolved

jasl force-pushed the amalgamation-traits-for-nft-types branch 2 times, most recently from 6abfae6 to bc6be4b Compare March 9, 2023 11:56

Add amalgamation traits for NFT CollectionId, ItemId, and DestroyWitness

b2e3b88

jasl force-pushed the amalgamation-traits-for-nft-types branch from bc6be4b to b2e3b88 Compare March 9, 2023 12:00

jasl requested a review from jsidorenko March 9, 2023 12:01

bkchr approved these changes Mar 9, 2023

View reviewed changes

jsidorenko reviewed Mar 9, 2023

View reviewed changes

frame/support/src/traits/tokens.rs Outdated Show resolved Hide resolved

Apply @bkchr suggests

cc29fe6

jasl force-pushed the amalgamation-traits-for-nft-types branch from 14c1b8b to cc29fe6 Compare March 9, 2023 15:41

jsidorenko approved these changes Mar 9, 2023

View reviewed changes

".git/.scripts/commands/fmt/fmt.sh"

6043b1f

paritytech-processbot bot merged commit 33eee69 into paritytech:master Mar 9, 2023

jasl deleted the amalgamation-traits-for-nft-types branch March 9, 2023 17:46

kiltbot mentioned this pull request Apr 3, 2023

3️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.39 to 0.9.40 KILTprotocol/kilt-node#496

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add amalgamation traits for NFT CollectionId and ItemId #13514

Add amalgamation traits for NFT CollectionId and ItemId #13514

jasl commented Mar 2, 2023 •

edited

Loading

jasl commented Mar 2, 2023

jasl commented Mar 2, 2023

jsidorenko commented Mar 3, 2023

jasl commented Mar 3, 2023

jasl commented Mar 3, 2023 •

edited

Loading

jsidorenko commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jasl commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jasl commented Mar 9, 2023

bkchr left a comment

jasl commented Mar 9, 2023

jasl commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

bkchr commented Mar 9, 2023

bkchr commented Mar 9, 2023

command-bot bot commented Mar 9, 2023 •

edited

Loading

command-bot bot commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jasl commented Mar 9, 2023

jasl commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

Add amalgamation traits for NFT CollectionId and ItemId #13514

Add amalgamation traits for NFT CollectionId and ItemId #13514

Conversation

jasl commented Mar 2, 2023 • edited Loading

jasl commented Mar 2, 2023

jasl commented Mar 2, 2023

jsidorenko commented Mar 3, 2023

jasl commented Mar 3, 2023

jasl commented Mar 3, 2023 • edited Loading

jsidorenko commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jasl commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jasl commented Mar 9, 2023

bkchr left a comment

Choose a reason for hiding this comment

jasl commented Mar 9, 2023

jasl commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

bkchr commented Mar 9, 2023

bkchr commented Mar 9, 2023

command-bot bot commented Mar 9, 2023 • edited Loading

command-bot bot commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jasl commented Mar 9, 2023

jasl commented Mar 9, 2023

jsidorenko commented Mar 9, 2023

jasl commented Mar 2, 2023 •

edited

Loading

jasl commented Mar 3, 2023 •

edited

Loading

command-bot bot commented Mar 9, 2023 •

edited

Loading