Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

client/beefy: drop justification on block import if pallet-beefy not enabled #13422

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

acatangiu
Copy link
Contributor

BEEFY pallet allows setting on-chain BEEFY genesis to some future block.

Disregard any BEEFY justifications attached to imported blocks that predate configured BEEFY genesis.

Fixes a memory "leak" or bloat where before this PR, "invalid/stale" justifications are enqueued on some channel to be processed by the voter, but the voter task doesn't process the queue until pallet is enabled.
With this PR, justifications are no longer enqueued until pallet is enabled; stale justifications are simply dropped.

BEEFY pallet allows setting on-chain BEEFY genesis to some future
block. Disregard any BEEFY justifications attached to imported blocks
that predate configured BEEFY genesis.

Signed-off-by: acatangiu <adrian@parity.io>
@acatangiu acatangiu self-assigned this Feb 20, 2023
@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 20, 2023
@acatangiu acatangiu merged commit abfa341 into paritytech:master Feb 20, 2023
@acatangiu acatangiu deleted the beefy-fix-leaky-block-import branch February 20, 2023 17:05
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
…itytech#13422)

BEEFY pallet allows setting on-chain BEEFY genesis to some future
block. Disregard any BEEFY justifications attached to imported blocks
that predate configured BEEFY genesis.

Signed-off-by: acatangiu <adrian@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
…itytech#13422)

BEEFY pallet allows setting on-chain BEEFY genesis to some future
block. Disregard any BEEFY justifications attached to imported blocks
that predate configured BEEFY genesis.

Signed-off-by: acatangiu <adrian@parity.io>
Ank4n pushed a commit that referenced this pull request Feb 28, 2023
)

BEEFY pallet allows setting on-chain BEEFY genesis to some future
block. Disregard any BEEFY justifications attached to imported blocks
that predate configured BEEFY genesis.

Signed-off-by: acatangiu <adrian@parity.io>
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
…itytech#13422)

BEEFY pallet allows setting on-chain BEEFY genesis to some future
block. Disregard any BEEFY justifications attached to imported blocks
that predate configured BEEFY genesis.

Signed-off-by: acatangiu <adrian@parity.io>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…itytech#13422)

BEEFY pallet allows setting on-chain BEEFY genesis to some future
block. Disregard any BEEFY justifications attached to imported blocks
that predate configured BEEFY genesis.

Signed-off-by: acatangiu <adrian@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants