Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use async/await instead of manual polling of NetworkWorker #13219

Merged
merged 43 commits into from
Feb 20, 2023
Merged

Use async/await instead of manual polling of NetworkWorker #13219

merged 43 commits into from
Feb 20, 2023

Commits on Jan 18, 2023

  1. Convert NetworkWorker::poll() into async next_action()

    @dmitry-markin
    dmitry-markin committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    fb272a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Use NetworkWorker::next_action instead of poll in sc-network-test

    @dmitry-markin
    dmitry-markin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    4b5d851 View commit details
    Browse the repository at this point in the history

  2. Revert "Use NetworkWorker::next_action instead of poll in `sc-net… 

    …work-test`"

This reverts commit 4b5d851.
    @dmitry-markin
    dmitry-markin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    1c87141 View commit details
    Browse the repository at this point in the history

  3. Fix sc-network-test to poll NetworkWorker::next_action

    @dmitry-markin
    dmitry-markin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    dbd8ad9 View commit details
    Browse the repository at this point in the history

  4. Fix sc_network::service tests to poll NetworkWorker::next_action

    @dmitry-markin
    dmitry-markin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e8d0758 View commit details
    Browse the repository at this point in the history

  5. Fix docs

    @dmitry-markin
    dmitry-markin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    3071b05 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    431e550 View commit details
    Browse the repository at this point in the history

  7. kick CI

    @dmitry-markin
    dmitry-markin committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d7be660 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Factor out next_worker_message() & next_swarm_event()

    @dmitry-markin
    dmitry-markin committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    78cce1a View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Error handling: replace futures::pending!() with expect()

    @dmitry-markin
    dmitry-markin committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    c9f75f7 View commit details
    Browse the repository at this point in the history

  2. Simplify stream polling in select!

    @dmitry-markin
    dmitry-markin committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4a85d1f View commit details
    Browse the repository at this point in the history

  3. Replace NetworkWorker::next_action() with run()

    @dmitry-markin
    dmitry-markin committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    c165185 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    d827ae9 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @dmitry-markin @bkchr
    dmitry-markin and bkchr authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    019ec35 View commit details
    Browse the repository at this point in the history

  6. minor: comment

    @dmitry-markin
    dmitry-markin committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    d38b2b7 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    343e9e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @dmitry-markin @bkchr
    dmitry-markin and bkchr authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    dd4980d View commit details
    Browse the repository at this point in the history

  2. Print debug log when network future is shut down

    @dmitry-markin
    dmitry-markin committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    403dded View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5a7ec32 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    73dfd4b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Evaluate NetworkWorker::run() future once before the loop

    @dmitry-markin
    dmitry-markin committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5a63842 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    913e21c View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Fix client code to match new NetworkService interfaces

    @dmitry-markin
    dmitry-markin committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    8e1db2c View commit details
    Browse the repository at this point in the history

  2. Make clippy happy

    @dmitry-markin
    dmitry-markin committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    faec2e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @dmitry-markin @bkchr
    dmitry-markin and bkchr authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9fa646d View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @dmitry-markin @bkchr
    dmitry-markin and bkchr authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9c5b610 View commit details
    Browse the repository at this point in the history

  3. Revert "Apply suggestions from code review" 

    This reverts commit 9fa646d.
    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    f324937 View commit details
    Browse the repository at this point in the history

  4. Make NetworkWorker::run() consume self

    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9856cc4 View commit details
    Browse the repository at this point in the history

  5. Terminate system RPC future if RPC rx stream has terminated.

    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    f86ec12 View commit details
    Browse the repository at this point in the history

  6. Rewrite with let-else

    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9557a42 View commit details
    Browse the repository at this point in the history

  7. Fix comments

    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    533cc04 View commit details
    Browse the repository at this point in the history

  8. Get best_seen_block and call on_block_finalized via ChainSync i… 

    …nstead of `NetworkService`
    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    e669c6a View commit details
    Browse the repository at this point in the history

  9. rustfmt

    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    6ed5d48 View commit details
    Browse the repository at this point in the history

  10. make clippy happy

    @dmitry-markin
    dmitry-markin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    ab1ced4 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Tests: schedule wake if next_action() returned true

    @dmitry-markin
    dmitry-markin committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4be62c7 View commit details
    Browse the repository at this point in the history

  2. minor: comment

    @dmitry-markin
    dmitry-markin committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5e90af0 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a9123a7 View commit details
    Browse the repository at this point in the history

  4. minor: fix NetworkWorker rustdoc

    @dmitry-markin
    dmitry-markin committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    113a888 View commit details
    Browse the repository at this point in the history

  5. minor: amend the rustdoc

    @dmitry-markin
    dmitry-markin committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ac1452c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Fix bug that caused on_demand_beefy_justification_sync test to hang

    @dmitry-markin
    dmitry-markin committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    5fc3831 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dm-network-service-… 

    …async-await
    @dmitry-markin
    dmitry-markin committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    6005109 View commit details
    Browse the repository at this point in the history

  3. rustfmt

    @dmitry-markin
    dmitry-markin committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9df7d0e View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Apply review suggestions

    @dmitry-markin
    dmitry-markin committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    812c316 View commit details
    Browse the repository at this point in the history