This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
revamp locking & reserving #13122
Closed
revamp locking & reserving #13122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
added
B7-runtimenoteworthy
C3-medium
github-actions
bot
added
the
A3-in_progress
sam0x17
force-pushed
the
sam-revamp-locking-and-reserving
branch
from
8e3081b
to
f34ce85
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
louismerlin
removed
the
D9-needsaudit 👮
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is our initial stab at paritytech/polkadot-sdk#236, which involves revisiting the definitions of free, locked, and reserved, especially as these concepts relate to voting, aucitions/crowdloans, and staking. In particular reserving will be replaced with "holding" via a type-safe
HoldReason, andThis will entail:
#[pallet::composite]syntax for definining composite enums that can then be used at the runtime levelHoldReason/ type-safe reserve/hold identifier via#[pallet::composite]FreezeReason/ type-safe lock/freeze identifier via#[pallet::composite]Related Issued