Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make CLI state pruning optional again #13017

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Commits on Dec 24, 2022

  1. Make CLI state pruning optional again

    The state pruning setting is stored in the database when it is created. In later runs it is fine to
    drop the `--state-pruning` CLI argument as the setting is stored in the database. The state db will
    only return an error if the stored state pruning doesn't match the state pruning given via CLI.
    
    Recently we improved the state pruning CLI handling and accidentally made the state pruning value
    always present (as we set some default value for the clap). If we could find out if a user has
    passed a value or the default value was taken, we could keep the default value in the CLI interface,
    but clap isn't supporting this right now. So, we need to go back and make `state_pruning` an
    optional with the default written into the docs.
    
    It also adds a test to ensure that we don't break this behavior again.
    bkchr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    13128b3 View commit details
    Browse the repository at this point in the history
  2. More docs

    bkchr committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    43951bb View commit details
    Browse the repository at this point in the history