Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Mmr client gadget - support pallet reset #12999

Merged
merged 5 commits into from
Dec 22, 2022
Merged

Mmr client gadget - support pallet reset #12999

merged 5 commits into from
Dec 22, 2022

Conversation

serban300
Copy link
Contributor

Prerequisite for fixing: #12864

@serban300 serban300 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 22, 2022
@serban300 serban300 self-assigned this Dec 22, 2022
svyatonik
svyatonik approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serban300 serban300 mentioned this pull request Dec 22, 2022
Closed
acatangiu
acatangiu approved these changes Dec 22, 2022
View reviewed changes
client/merkle-mountain-range/src/aux_schema.rs Outdated Show resolved Hide resolved
client/merkle-mountain-range/src/offchain_mmr.rs Outdated Show resolved Hide resolved
serban300 and others added 2 commits December 22, 2022 12:20
@serban300 @acatangiu
Rename update_first_mmr_block
924499c 
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@serban300
Renamings
af9aa2e
@serban300
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 708626f into paritytech:master Dec 22, 2022
@AurevoirXavier AurevoirXavier mentioned this pull request Feb 8, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@serban300 @acatangiu @ltfschoen
Mmr client gadget - support pallet reset (paritytech#12999)
24b9997 
* Remove unneeded code

* Moving some code

* Support pallet-mmr reset

* Rename update_first_mmr_block

Co-authored-by: Adrian Catangiu <adrian@parity.io>

* Renamings

Co-authored-by: Adrian Catangiu <adrian@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@serban300 @acatangiu @ark0f
Mmr client gadget - support pallet reset (paritytech#12999)
4df76dc 
* Remove unneeded code

* Moving some code

* Support pallet-mmr reset

* Rename update_first_mmr_block

Co-authored-by: Adrian Catangiu <adrian@parity.io>

* Renamings

Co-authored-by: Adrian Catangiu <adrian@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@svyatonik svyatonik svyatonik approved these changes

@acatangiu acatangiu acatangiu approved these changes

@Lederstrumpf Lederstrumpf Awaiting requested review from Lederstrumpf

Assignees

@serban300 serban300

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serban300 @svyatonik @acatangiu