This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Referendum decision period quantization #12810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
A0-please_review
muharem
changed the title
muharem
commented
Nov 30, 2022
| @@ -754,9 +759,6 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> { | |||
| call: BoundedCallOf<T, I>, | |||
| when: T::BlockNumber, | |||
| ) -> Option<(T::BlockNumber, ScheduleAddressOf<T, I>)> { | |||
| let alarm_interval = T::AlarmInterval::get().max(One::one()); | |||
| let when = when.saturating_add(alarm_interval).saturating_sub(One::one()) / | |||
| (alarm_interval.saturating_mul(alarm_interval)).max(One::one()); | |||
There was a problem hiding this comment.
its probably supposed to be calculated from the duration.
I moved this logic to decision_alarm, because we need the quantization only for the decision period.
The preparation and confirmation period has to pass fully for each stage, at least this how I understand it.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
gavofyork
reviewed
Nov 30, 2022
| /// Minimum alarm period for the referendum wakeup scheduler during the decision stage. | ||
| /// Prevents wake up calls from being too frequent as a result of the quantization. | ||
| #[pallet::constant] | ||
| type MinAlarmPeriod: Get<Self::BlockNumber>; |
There was a problem hiding this comment.
What's the actual use-case for this?
|
Please add a test. |
|
Please see #12815 and check if it passes your test. |
|
Closing in favor of this pr #12815 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if
AlarmIntervalset to > 1, the time for alarm will be calculated to the past, and scheduler will fail.This PR fixes it.