Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Only use substrate-wasm-builder when std feature is enabled. #12790

Merged

Conversation

nazar-pc
Copy link
Contributor

This is a much simpler version of #12786 that achieves the same result. Mostly an example for other projects to follow.

jasl added a commit to Phala-Network/khala-parachain that referenced this pull request Dec 14, 2022
@stale
Copy link

stale bot commented Dec 31, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Dec 31, 2022
@nazar-pc
Copy link
Contributor Author

nazar-pc commented Jan 6, 2023

@bkchr is there anything else that needs to be done here?

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 6, 2023
@bkchr
Copy link
Member

bkchr commented Jan 6, 2023

@bkchr is there anything else that needs to be done here?

No! Just a second approval is missing :D

@bkchr
Copy link
Member

bkchr commented Jan 6, 2023

bot rebase

@bkchr bkchr requested a review from a team January 6, 2023 08:38
@paritytech-processbot
Copy link

Rebased

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 6, 2023
@bkchr
Copy link
Member

bkchr commented Jan 6, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants