Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename from_components to from_parts #12473

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

KiChjang
Copy link
Contributor

Simple PR that renames the from_components method to from_parts

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 11, 2022
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does obviously not compile like this.

@KiChjang KiChjang requested a review from athei as a code owner October 11, 2022 15:22
@KiChjang
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1bf2e6d into master Oct 11, 2022
@paritytech-processbot paritytech-processbot bot deleted the kckyeung/rename-weight-constructor branch October 11, 2022 16:35
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis/1026/2

ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Rename `from_components` to `from_parts`

* Fixes

* Spelling
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants