This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add base-weight to System::Extrinsic* events
#12329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
ggwpez
changed the title
ExtrinsicSuccessSystem::Extrinsic* events
bkchr
approved these changes
Sep 22, 2022
shawntabrizi
approved these changes
Sep 23, 2022
|
@ggwpez now you just need to fix the tests. |
|
bot merge |
1 task
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Add base-weight to events Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix test Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12252:
note_applied_extrinsic.Operationalclass a distinct base weight, to improve testing.PolkadotJs now also shows the correct weight of a Remark:
87_298_000 = 86_298_000 (base) + 1_000_000 (remark).This is identical to the result of
System::blockWeight(block_hash)in that case.cc @notlesh